Updates based on feedback

Dockerfile

@@ -13,8 +13,7 @@ COPY rfSsdpServer.py redfishMockupServer.py /usr/src/app/
 ADD public-rackmount1 /usr/src/app/public-rackmount1
 
 # Env settings
-ENV INSIDE_DOCKER_CONTAINER Yes
 EXPOSE 8000
 HEALTHCHECK CMD curl --fail http://127.0.0.1:8000/redfish/v1 || exit 1
 WORKDIR /usr/src/app
-ENTRYPOINT ["python", "/usr/src/app/redfishMockupServer.py"]
+ENTRYPOINT ["python", "/usr/src/app/redfishMockupServer.py", "-H", "0.0.0.0"]

README.md

@@ -63,7 +63,7 @@ If no mockup is specified, the mockup server will serve the DMTF's "public-rackm
 
 If running as a Docker container, you can either:
 * Pull the container from Docker Hub: `docker pull dmtf/redfish-mockup-server:latest`
-* Build a container from source: `docker build -t dmtf/redfish-mockup-server:latest`
+* Build a container from source: `docker build -t dmtf/redfish-mockup-server:latest .`
 
 The following will run the container using the built-in "public-rackmount1" mockup:
 ```bash

redfishMockupServer.py

@@ -19,7 +19,6 @@
 import os
 import ssl
 import logging
-import socket
 from http.server import BaseHTTPRequestHandler, HTTPServer
 from urllib.parse import urlparse, urlunparse, parse_qs
 from rfSsdpServer import RfSSDPServer
@@ -695,11 +694,6 @@ def main():
         shortForm = args.short_form
         ssdpStart = args.ssdp
 
-        # If inside a Docker container, expose on all interfaces
-        if os.environ.get('INSIDE_DOCKER_CONTAINER', False):
-            hostname=socket.gethostbyname(socket.gethostname())
-            port=8000
-
         # check if mockup path was specified.  If not, use the built-in mockup
         if mockDirPath is None:
             mockDirPath = 'public-rackmount1'