Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Feature/734 bootstrap theme #744

Merged

Conversation

Timo-Breumelhof
Copy link
Contributor

First version of a Bootstrap based theme

Changes made

  • Added a theme ;-)
  • Item 2

How did you test these updates?

Local install

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

#734

Close #

@Timo-Breumelhof Timo-Breumelhof added the enhancement New feature or request label Apr 9, 2024
@Timo-Breumelhof Timo-Breumelhof self-assigned this Apr 9, 2024
@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley @WillStrohl first version of a bootstrap based Theme

@johnhenley
Copy link
Collaborator

@Timo-Breumelhof should this work with default DNN site? (Xcillion?)

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley eh no, that's bootstrap 3 AFAIK. This is for bootstrap 4/5
I'll have to change the readme

@johnhenley
Copy link
Collaborator

@Timo-Breumelhof ok. So test on local copy of dnncommunity?

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley yes. Although my tests have been on Bootstrap4 and that one is Bootstrap 5.
But it would be a good test..

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley I had not thought about Xcillion being v3 (I never use it)
Maybe we can add some "hack" css to support it?
BTS3 is really old...
(TBH Xcillion should have been updated to BTS4/5 years ago)

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley I just committed a new readme.md

@johnhenley
Copy link
Collaborator

@johnhenley I had not thought about Xcillion being v3 (I never use it)

Maybe we can add some "hack" css to support it?

BTS3 is really old...

(TBH Xcillion should have been updated to BTS4/5 years ago)

Well isn't it the default DNN "user experience"? If there isn't a plan to update it, and the community-default theme seems to be fine with it, should that be added to both of the community-* theme readmes? We aren't planning to change community-default at this time, correct?

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley True they can use community-default

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley readme.md adjusted accordingly

@Timo-Breumelhof Timo-Breumelhof merged commit 271b30e into DNNCommunity:dev Apr 9, 2024
1 check passed
@johnhenley johnhenley added this to the 08.01.00 milestone May 10, 2024
@Timo-Breumelhof Timo-Breumelhof deleted the feature/734-Bootstrap-Theme branch May 15, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants