Allow for trailing comments in lists #1162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for comments trailing an entry without dropping the whole line.
Allow for comments trailing an entry without dropping the whole line.
Allow for comments trailing an entry without dropping the whole line.
Allow for comments trailing an entry without dropping the whole line.
Allow for comments trailing an entry without dropping the whole line.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature addition for behavior similar to hosts file.
The hash (#) symbol and trailing characters are dropped.
Example line: www.example.com #comment
Current Behavior: Line is ignored.
Proposed Behavior: "www.example.com" is used.
Example line: #www.example.com #comment
Current Behavior: Line is ignored.
Proposed Behavior: Line is truncated to "" and ignored.
Potential hazards:
Will break users' current lists that rely on the hash symbol to invalidate lines.
Potential performance degradation when reading large lists.
Reference: #1158