Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with settings #12

Open
1 task done
stdmje opened this issue Jul 27, 2022 · 1 comment
Open
1 task done

Error with settings #12

stdmje opened this issue Jul 27, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@stdmje
Copy link

stdmje commented Jul 27, 2022

Contact Details (optional)

No response

Description. What happened?

When trying to pass values using settings i got an error.

Steps to reproduce

  settings = {
    nodeSelector = {
      OnDemand = "true"
    }
  }

Expected behavior

No response

Actual behavior

│ Error: error getting values for a diff: ---> error unmarshaling JSON: while decoding JSON: json: cannot unmarshal string into Go value of type map[string]interface {} "{\"nodeSelector\":{\"OnDemand\":\"true\"}}"
│
│
│   with helm_release.kubernetes_efs_csi_driver[0],
│   on helm.tf line 1, in resource "helm_release" "kubernetes_efs_csi_driver":
│    1: resource "helm_release" "kubernetes_efs_csi_driver" {
│
╵
Releasing state lock. This may take a few moments...

Occurrence

Frequently

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@stdmje stdmje added the bug Something isn't working label Jul 27, 2022
@kylebisley
Copy link

kylebisley commented Jun 14, 2023

I am also struggling to set the nodeSelector in the helm deployment.

I'd be happy to add to the documentation an example of how to set values through the settings object as it is a bit vague at the moment but I'm fairly convinced that it cannot do what I need so I'm following this bug .

Issue could lead me to abandoning this module and rolling my own as this functionality is essential for my use case.

Edit:

Solved
Sorted it out with some good old fashion bruit force permutation. Convinced this is just a documentation issue now. Adding my solution here for posterity until I can get a pull request up for the documentation.

Setting the Controller nodeSelector

  settings = {
      "controller" = { 
        "nodeSelector" = {
          "deployment" = "dev"
          } 
      }
  }

or using the kubernetes example

  settings = {
      "controller" = { 
        "nodeSelector" = {
          "disktype" = "ssd"
          } 
      }
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants