Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude nominee: Open Source Society University #814

Merged
merged 9 commits into from
Dec 7, 2021

Conversation

lacabra
Copy link
Contributor

@lacabra lacabra commented Oct 19, 2021

Automatic addition of a new nominee submitted through the online form available at https://digitalpublicgoods.net/submission

@nathanbaleeta
Copy link
Contributor

nathanbaleeta commented Nov 4, 2021

@conradsp @lacabra proposing to close this PR as it is low quality considering:

  • No contact information is provided for easy follow up
  • It indicates an invalid license (MIT) for open content

@conradsp
Copy link
Collaborator

conradsp commented Nov 5, 2021

Agreed @nathanbaleeta - it's aggregating courses from several different platforms (edX, coursera, etc), which potentially have different licensing structures.

@lacabra
Copy link
Contributor Author

lacabra commented Nov 5, 2021

@nathanbaleeta Agreed.

But rather than closing without merging, I would ask you to move this file to the excluded-nominees/ folder and add a line to the README.md in that folder capturing the decision we have agreed to so that we have a record of it.

Thanks!

@nathanbaleeta nathanbaleeta changed the title Add nominee: open-source-society-university Add nominee: Open Source Society University Dec 1, 2021
@nathanbaleeta nathanbaleeta changed the title Add nominee: Open Source Society University Exclude nominee: Open Source Society University Dec 1, 2021
Copy link
Contributor Author

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @nathanbaleeta

Copy link
Collaborator

@conradsp conradsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathanbaleeta - I am not sure how the exclusion process works. Should the original file still be in the nominees directory as is configured currently in this PR?

@nathanbaleeta
Copy link
Contributor

@nathanbaleeta - I am not sure how the exclusion process works. Should the original file still be in the nominees directory as is configured currently in this PR?

@conradsp resolved in commit f02fbf5

@nathanbaleeta nathanbaleeta merged commit e387e6e into main Dec 7, 2021
@nathanbaleeta nathanbaleeta deleted the opensourcesocietyuniversity-zh9fve41w1.i branch December 7, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants