Skip to content

Commit

Permalink
#968 Resolves issue with clearing alias ID overlap state when the use…
Browse files Browse the repository at this point in the history
…r edits the alias to correct the overlap.
  • Loading branch information
Dennis Sheirer committed Nov 9, 2023
1 parent 09e19e1 commit 8845306
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
Expand Up @@ -387,7 +387,7 @@ private TableView<Alias> getAliasTableView()
idsColumn.setCellValueFactory(new IdentifierCountCell());

TableColumn<Alias, Boolean> errorsColumn = new TableColumn<>("Error");
errorsColumn.setPrefWidth(80);
errorsColumn.setPrefWidth(120);
errorsColumn.setCellValueFactory(new PropertyValueFactory<>("overlap"));
errorsColumn.setCellFactory(param ->
{
Expand Down
Expand Up @@ -362,7 +362,10 @@ public void save()
for(AliasID aliasID: getIdentifiersList().getItems())
{
//Create a copy of the identifier so that the alias and the editor don't have the same instance
alias.addAliasID(AliasFactory.copyOf(aliasID));
//and reset the overlap flag (if set) so that the alias list can reevaluate the overlap state.
AliasID copy = AliasFactory.copyOf(aliasID);
copy.setOverlap(false);
alias.addAliasID(copy);
}

//Remove and replace alias actions
Expand Down
Expand Up @@ -123,7 +123,7 @@ else if(frequency < 250_000_000)
}
catch(UsbException e)
{
throw new SourceException("R820TTunerController - exception while setting frequency [" + frequency + "] - " +
throw new SourceException("R828DTunerController - exception while setting frequency [" + frequency + "] - " +
e.getLocalizedMessage());
}
finally
Expand Down

0 comments on commit 8845306

Please sign in to comment.