Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events Tab Shows Duplicate Events #1603

Closed
jpryor223 opened this issue Jul 14, 2023 · 5 comments · Fixed by #1608
Closed

Events Tab Shows Duplicate Events #1603

jpryor223 opened this issue Jul 14, 2023 · 5 comments · Fixed by #1608
Assignees
Labels
Milestone

Comments

@jpryor223
Copy link

sdrtrunk Version
Version 0.6.0 Alpha 7

Describe the bug
The Now Playing > active Channel > Events sub panel > "Duration" column value rendering process is adding new rows continuously with incrementing duration time values while an active call plays.

To Reproduce
Steps to reproduce the behavior:

  1. Go to and click on a Status CALL active channel in Now Playing.
  2. Click on the "Events" sub panel.
  3. View the incrementing Duration values and new rows being added while the channel is active.

Expected behavior
In previous versions (Alpha 6 and prior) the Duration column current row value would increment the duration value only, and not add new rows as the active call progressed.

Screenshots
Active Channel with Events Duration repeating rows (during active channel):
image

Idle Channel with no Events Duration repeated rows (leave channel and come back to idle channel):
image

Application Log
N/A, no error in application log. This Bug is visible in Events sub panel.

Desktop (optional - complete the following information):

  • OS: Windows 10
  • CPU Cores: 4
  • RAM: 8GB

Additional context
Able to reproduce the Events Duration repeating rows with AM, NBFM (with and without DCS decoder enabled), P25-1 conventional channel and trunking traffic channel Decoders.
After leaving the active channel and coming back to a previous idle channel, the Events sub panel no longer shows the repeating rows.
Also noted by and further screen shots in Discord from user "M.C.B.": https://discord.com/channels/565715676749103115/565715676749103117/1129496726022131752

@jpryor223 jpryor223 added the bug label Jul 14, 2023
@linuxnut79
Copy link

linuxnut79 commented Jul 15, 2023

i also have this issue.

Ubuntu 22.04 x64
Gnome 42.9
12gb RAM
i5-4570
4x RTL-SDR

@dave3825us
Copy link

I have this issue also. Win 10 64 bit

@Ctpolicelive
Copy link

Ctpolicelive commented Jul 17, 2023

Same issue on Linux.. Also if you slide the event slider lower and then toggle any filter on and off. Then if you go back and slide the slider again it loses all channel aliases and other info in events and just repeats (Identifier Collection Timeslot)

Only way to fix is to reset the program.

Untitlsdrtrunked
Alt text

@gingerhax
Copy link

Same issue, MacOS

@Seagravebuff60
Copy link

Same issue here. Im actually the original one who reported it in Discord. https://discord.com/channels/565715676749103115/565715676749103117/1129496726022131752

@DSheirer DSheirer self-assigned this Jul 22, 2023
@DSheirer DSheirer added this to the Build 0.6.0 milestone Jul 22, 2023
@DSheirer DSheirer changed the title Version 0.6.0 Alpha 7 > Now Playing > Channel > Events sub panel > Duration value rendering adding rows Events Tab Shows Duplicate Events Jul 22, 2023
DSheirer pushed a commit that referenced this issue Jul 22, 2023
…n values to display correctly and minimize the quantity of duplicate events.
DSheirer pushed a commit that referenced this issue Jul 22, 2023
…n values to display correctly and minimize the quantity of duplicate events.
DSheirer added a commit that referenced this issue Jul 22, 2023
tadscottsmith added a commit to tadscottsmith/sdrtrunk that referenced this issue Aug 7, 2023
* DSheirer#1529 Adds logging suppression to Broadcaster to limit total logged error messages. (DSheirer#1530)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1531 Updates version to 0.6.0 alpha 7 (DSheirer#1532)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* Revert "DSheirer#1531 Updates version to 0.6.0 alpha 7 (DSheirer#1532)"

This reverts commit 11f37e8.

* DSheirer#35 Updates AM & NBFM decoders to use Adaptive Squelch, a power squelch that includes an adaptive noise floor monitor.  Implements vectorized magnitude operations for AM & FM decoders.  Adds talkgroup assignment and squelch controls to AM channel configuration editor.  Implements new AM gain control that attempts to normalize audio gain quickly at beginning of call/transmission and maintains that gain across lifecycle of the call and resets the gain for the next call. (DSheirer#1540)

Notes on usage:
- When using either AM or FM squelch control use either the Heterodyne channelizer or if using the Polyphase channelizer, avoid using trunk tracking decoders like DMR or P25 or set the squelch threshold high enough to avoid changes in noise floor from polyphase channelizer where it can vary between using the one channel or the two-channel combined channel sources.

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1528 Restores consistent audio segment start tone insertion, broken in DSheirer#1506 (DSheirer#1543)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#648 Resolves issue with audio panel sometimes displaying stale metadata that doesn't clear until the next audio segment is loaded. (DSheirer#1545)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1507 Resolves issue with Cap+ LSN parsing.  Updates Cap+ Site Status and adds RAS bit handling. (DSheirer#1536)

Co-authored-by: Matthew Foster <matthew.foster@noaa.gov>

* Adds native Rdio Scanner streaming. (#1) (DSheirer#1476)

DSheirer#1476 Adds rdio-scanner call upload API streaming support
---------

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1556 DMR Capacity Plus parsing enhancements. (DSheirer#1557)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* added Rsp1TunerConfiguration to JsonSubTypes of RspTunerConfiguration (DSheirer#1555)

Following reports that RSP1 tuner configurations are reset to default on startup. Unable to test

* DSheirer#1548 Reduces default decoder AF gain by 40% to resolve issue with distorted audio from local strong aircraft transmissions. (DSheirer#1559)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1547 Updates playlist alias editor to make add/delete operations more efficient. (DSheirer#1560)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1558 Resolves issue where heterodyne channelizer allows tuning a set of channels that exceed the tuner's bandwidth. (DSheirer#1561)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1565 updates LTR, LTRNet and Passport decoders with new slope decoder.  Resolves issue with LTR Standard decoder state that was combining individual calls to the same talkgroup and causing excessively long calls. (DSheirer#1567)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1568 Updates NBFM decoder configuration so user can enable/disable high-pass filter option in the audio module to effect audio playback and audio recording of the demodulated audio.  Disabling the filter allows recording of DC and sub-audible signalling that may be present in the demodulated audio (e.g. LTR or squelching signalling). (DSheirer#1569)

Co-authored-by: sheirerd <sheirerd@ainfosec.com>

* DSheirer#1573 Adds Digital Coded Squelch (DCS) auxiliary decoder support. (DSheirer#1574)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1575 Updates traffic channel names to be 'T-' concatenated with the parent control channel name from the channel configuration. (DSheirer#1578)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1579 Resolves issue with array index out of bounds error generated in P25 Phase 1 decoders where the Dibit circular buffer attempts to write a (DSheirer#1580)

dibit past the length of the array.  Issue likely occurs when a partial/incomplete put operation adds a dibit and increments the buffer pointer but the thread is interrupted prior to wrapping the buffer pointer.  When the next runnable iteration executes, the pointer is pointing past the end of the buffer.  Updates the code to check the pointer both before and after the put operation.

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1581 Updates Rdio Scanner configuration editor to automatically append the 'api/call-upload' path to the end of the protocol and host value provided by the user.  Sets the host default value to 'http://localhost' but allows the user to overwrite. (DSheirer#1582)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1563 Updates RSP tuner to produce sample buffers with optimal power-of-2 length to enable downstream vectorized operations. (DSheirer#1583)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1584 Updates DMR & P25 decoders to stop processing residual samples from the current buffer after a traffic channel shutdown has been signalled. (DSheirer#1585)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1590 Resolves issue with RSP tuners generating too many native buffers causing excessive memory consumption (DSheirer#1591)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1588 Use JDK20 and Gradle 8.2.  Updates SDRPlay API for compatibility with JDK20 Project Panama Foreign Memory/Function changes. (DSheirer#1589)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1586 Resolves issue in P25 message framer where after transmitting the current message the mDataUnitId is set to null and this causes an NPE when subsequent code is executed prior to shutdown of the channel. (DSheirer#1593)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* Adds event type as a filtering option in the Events tab

* DSheirer#1368 Restructures Message and Event filter framework.

* DSheirer#1603 Resolves issue with de-duplicating events to allow call duration values to display correctly and minimize the quantity of duplicate events.

* DSheirer#1604 Resolves issue with event panel UI layout creating excess space between history management panel and events table.

* DSheirer#1605 Resolves issue where certain Linux users were unable to display the tuner editor panel due to an issue with the frequency control editor's usage of custom cursor.

* DSheirer#1612 Enhance aliasing to support DCS tones

---------

Co-authored-by: Denny Sheirer <dennissheirer2002@yahoo.com>
Co-authored-by: Dennis Sheirer <dsheirer@github.com>
Co-authored-by: wedgef5 <wedgef5@users.noreply.github.com>
Co-authored-by: Matthew Foster <matthew.foster@noaa.gov>
Co-authored-by: Nokoa <Nokoa@users.noreply.github.com>
Co-authored-by: sheirerd <sheirerd@ainfosec.com>
Co-authored-by: Christopher Varner <rdhddood@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants