Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create AM Squelch Control #35

Closed
DSheirer opened this issue Nov 29, 2015 · 4 comments · Fixed by #1540
Closed

Create AM Squelch Control #35

DSheirer opened this issue Nov 29, 2015 · 4 comments · Fixed by #1540
Assignees
@DSheirer
Labels
enhancement low
Milestone
Version 0.6.0

Comments

@DSheirer
Copy link
Owner

Create a squelch control for the AM decoder
@DSheirer DSheirer added this to the Build 0.3.0 milestone Nov 29, 2015
@DSheirer DSheirer modified the milestones: Build 0.3.1, Build 0.3.0 Feb 15, 2016
@DSheirer DSheirer modified the milestones: Build 0.4.0, Build 0.3.1 Feb 15, 2016
@chudgoo chudgoo mentioned this issue Oct 16, 2017
Closed
@ah1102
Copy link

ah1102 commented Apr 28, 2020

I would also like to see in the program noise reduction for analog FM and AM. I also noticed an echo in NFM.

The program may be more universal. With hackrf, it would be possible to have multichannel reception on the air or amateur radio.

@DSheirer DSheirer mentioned this issue Mar 26, 2022
Closed
@ah1102
Copy link

ah1102 commented Jan 25, 2023

Dear developer! Enter squelch for AM. It is not difficult to add it for AM, taking it from the NBFM mode. Just add a similar feature for AM.

@DSheirer DSheirer self-assigned this Apr 16, 2023
DSheirer pushed a commit that referenced this issue Apr 21, 2023
#35 Creates scalar and vector implementations for AM and Magnitude an…
facabd2 
…d resolves issue with Scalar FM demodulator that was preventing unsquelch and audio playback.
DSheirer pushed a commit that referenced this issue Apr 21, 2023
#35 WIP AM squelching demodulator.
c6200a8
DSheirer pushed a commit that referenced this issue Apr 22, 2023
#35 Functional AM demodulator with squelch control.
3fa01c3
DSheirer pushed a commit that referenced this issue Apr 23, 2023
#35 Adds alias support and WIP on tweaking the AGC ... AGC needs more…
fa5df3a 
… work.
DSheirer pushed a commit that referenced this issue Apr 28, 2023
#35 Update replay controller to produce sample buffers as multiple of…
d4431e7 
… 256 samples.
DSheirer pushed a commit that referenced this issue Apr 28, 2023
#35 WIP on dialing in the AM decoder gain and the AGC control.
ff4b7ef
DSheirer pushed a commit that referenced this issue Apr 30, 2023
#35 WIP new ObjectiveGainControl
4147f75
@DSheirer
Copy link
Owner Author

DSheirer commented May 2, 2023

AM squelch control implemented in branch. AM & FM now share common squelch control code. Need to add dynamic channel noise floor monitoring to auto-adjust squelch threshold and change the squelch threshold to be a value that's added to the current noise floor.
20230502_074623_screen_capture

DSheirer pushed a commit that referenced this issue May 2, 2023
#35 WIP Updated AM decoder to adjust demodulator gain and implemented…
749613c 
… new Gain and DC removal control that attempts to normalize audio gain toward an objective value.
DSheirer pushed a commit that referenced this issue May 5, 2023
#35 WIP. Adds auto-tracking of the noise floor to auto-adjust the squ…
ad4372f 
…elch threshold every 5 seconds to maintain a consistent squelch buffer above the noise floor. Updates channel power panel UI to include new 'Auto-Track' switch to enable/disable the feature. I still have to add code to auto-update the channel configuration whenever the user adjusts the auto-track option.
DSheirer pushed a commit that referenced this issue May 6, 2023
#35 WIP adds configuration updating.
16605ce
DSheirer pushed a commit that referenced this issue May 7, 2023
#35 WIP. Adds auto-tracking of the noise floor to auto-adjust the squ…
e090944 
…elch threshold every 5 seconds to maintain a consistent squelch buffer above the noise floor. Updates channel power panel UI to include new 'Auto-Track' switch to enable/disable the feature. I still have to add code to auto-update the channel configuration whenever the user adjusts the auto-track option.

#35 WIP Updated AM decoder to adjust demodulator gain and implemented new Gain and DC removal control that attempts to normalize audio gain toward an objective value.
#35 Functional AM demodulator with squelch control.
#35 Creates scalar and vector implementations for AM and Magnitude and resolves issue with Scalar FM demodulator that was preventing unsquelch and audio playback.
DSheirer pushed a commit that referenced this issue May 7, 2023
#35 WIP. Adds auto-tracking of the noise floor to auto-adjust the squ…
39cb405 
…elch threshold every 5 seconds to maintain a consistent squelch buffer above the noise floor. Updates channel power panel UI to include new 'Auto-Track' switch to enable/disable the feature. I still have to add code to auto-update the channel configuration whenever the user adjusts the auto-track option.

#35 WIP Updated AM decoder to adjust demodulator gain and implemented new Gain and DC removal control that attempts to normalize audio gain toward an objective value.
#35 Functional AM demodulator with squelch control.
#35 Creates scalar and vector implementations for AM and Magnitude and resolves issue with Scalar FM demodulator that was preventing unsquelch and audio playback.
DSheirer pushed a commit that referenced this issue May 7, 2023
#35 WIP. AM decoder complete.
968249a
DSheirer pushed a commit that referenced this issue May 7, 2023
#35 WIP. FM decoder updated to use adaptive squelch.
67a7513
DSheirer pushed a commit that referenced this issue May 7, 2023
#35 Updates AM & NBFM decoders to use Adaptive Squelch, a power squel…
2588d2e 
…ch that includes an adaptive noise floor monitor. Implements vectorized magnitude operations for AM & FM decoders. Adds talkgroup assignment and squelch controls to AM channel configuration editor. Implements new AM gain control that attempts to normalize audio gain quickly at beginning of call/transmission and maintains that gain across lifecycle of the call and resets the gain for the next call.

Notes on usage:
- When using either AM or FM squelch control use either the Heterodyne channelizer or if using the Polyphase channelizer, avoid using trunk tracking decoders like DMR or P25 or set the squelch threshold high enough to avoid changes in noise floor from polyphase channelizer where it can vary between using the one channel or the two-channel combined channel sources.
@DSheirer DSheirer mentioned this issue May 7, 2023
Merged
DSheirer pushed a commit that referenced this issue May 7, 2023
#35 WIP. Code review.
ce95932
DSheirer pushed a commit that referenced this issue May 7, 2023
#35 Updates AM & NBFM decoders to use Adaptive Squelch, a power squel…
dab61ed 
…ch that includes an adaptive noise floor monitor. Implements vectorized magnitude operations for AM & FM decoders. Adds talkgroup assignment and squelch controls to AM channel configuration editor. Implements new AM gain control that attempts to normalize audio gain quickly at beginning of call/transmission and maintains that gain across lifecycle of the call and resets the gain for the next call.

Notes on usage:
- When using either AM or FM squelch control use either the Heterodyne channelizer or if using the Polyphase channelizer, avoid using trunk tracking decoders like DMR or P25 or set the squelch threshold high enough to avoid changes in noise floor from polyphase channelizer where it can vary between using the one channel or the two-channel combined channel sources.
DSheirer added a commit that referenced this issue May 7, 2023
@DSheirer
#35 Updates AM & NBFM decoders to use Adaptive Squelch, a power squel…
4f8b8e9 
…ch that includes an adaptive noise floor monitor. Implements vectorized magnitude operations for AM & FM decoders. Adds talkgroup assignment and squelch controls to AM channel configuration editor. Implements new AM gain control that attempts to normalize audio gain quickly at beginning of call/transmission and maintains that gain across lifecycle of the call and resets the gain for the next call. (#1540)

Notes on usage:
- When using either AM or FM squelch control use either the Heterodyne channelizer or if using the Polyphase channelizer, avoid using trunk tracking decoders like DMR or P25 or set the squelch threshold high enough to avoid changes in noise floor from polyphase channelizer where it can vary between using the one channel or the two-channel combined channel sources.

Co-authored-by: Dennis Sheirer <dsheirer@github.com>
@DSheirer
Copy link
Owner Author

DSheirer commented May 7, 2023

Closed via PR.

@DSheirer DSheirer closed this as completed May 7, 2023
tadscottsmith added a commit to tadscottsmith/sdrtrunk that referenced this issue Aug 7, 2023
@tadscottsmith @DSheirer
@wedgef5 @Nokoa @VolFFProCoder
Merge in master. (#2)
e42d7a9 
* DSheirer#1529 Adds logging suppression to Broadcaster to limit total logged error messages. (DSheirer#1530)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1531 Updates version to 0.6.0 alpha 7 (DSheirer#1532)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* Revert "DSheirer#1531 Updates version to 0.6.0 alpha 7 (DSheirer#1532)"

This reverts commit 11f37e8.

* DSheirer#35 Updates AM & NBFM decoders to use Adaptive Squelch, a power squelch that includes an adaptive noise floor monitor.  Implements vectorized magnitude operations for AM & FM decoders.  Adds talkgroup assignment and squelch controls to AM channel configuration editor.  Implements new AM gain control that attempts to normalize audio gain quickly at beginning of call/transmission and maintains that gain across lifecycle of the call and resets the gain for the next call. (DSheirer#1540)

Notes on usage:
- When using either AM or FM squelch control use either the Heterodyne channelizer or if using the Polyphase channelizer, avoid using trunk tracking decoders like DMR or P25 or set the squelch threshold high enough to avoid changes in noise floor from polyphase channelizer where it can vary between using the one channel or the two-channel combined channel sources.

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1528 Restores consistent audio segment start tone insertion, broken in DSheirer#1506 (DSheirer#1543)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#648 Resolves issue with audio panel sometimes displaying stale metadata that doesn't clear until the next audio segment is loaded. (DSheirer#1545)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1507 Resolves issue with Cap+ LSN parsing.  Updates Cap+ Site Status and adds RAS bit handling. (DSheirer#1536)

Co-authored-by: Matthew Foster <matthew.foster@noaa.gov>

* Adds native Rdio Scanner streaming. (#1) (DSheirer#1476)

DSheirer#1476 Adds rdio-scanner call upload API streaming support
---------

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1556 DMR Capacity Plus parsing enhancements. (DSheirer#1557)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* added Rsp1TunerConfiguration to JsonSubTypes of RspTunerConfiguration (DSheirer#1555)

Following reports that RSP1 tuner configurations are reset to default on startup. Unable to test

* DSheirer#1548 Reduces default decoder AF gain by 40% to resolve issue with distorted audio from local strong aircraft transmissions. (DSheirer#1559)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1547 Updates playlist alias editor to make add/delete operations more efficient. (DSheirer#1560)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1558 Resolves issue where heterodyne channelizer allows tuning a set of channels that exceed the tuner's bandwidth. (DSheirer#1561)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1565 updates LTR, LTRNet and Passport decoders with new slope decoder.  Resolves issue with LTR Standard decoder state that was combining individual calls to the same talkgroup and causing excessively long calls. (DSheirer#1567)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1568 Updates NBFM decoder configuration so user can enable/disable high-pass filter option in the audio module to effect audio playback and audio recording of the demodulated audio.  Disabling the filter allows recording of DC and sub-audible signalling that may be present in the demodulated audio (e.g. LTR or squelching signalling). (DSheirer#1569)

Co-authored-by: sheirerd <sheirerd@ainfosec.com>

* DSheirer#1573 Adds Digital Coded Squelch (DCS) auxiliary decoder support. (DSheirer#1574)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1575 Updates traffic channel names to be 'T-' concatenated with the parent control channel name from the channel configuration. (DSheirer#1578)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1579 Resolves issue with array index out of bounds error generated in P25 Phase 1 decoders where the Dibit circular buffer attempts to write a (DSheirer#1580)

dibit past the length of the array.  Issue likely occurs when a partial/incomplete put operation adds a dibit and increments the buffer pointer but the thread is interrupted prior to wrapping the buffer pointer.  When the next runnable iteration executes, the pointer is pointing past the end of the buffer.  Updates the code to check the pointer both before and after the put operation.

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1581 Updates Rdio Scanner configuration editor to automatically append the 'api/call-upload' path to the end of the protocol and host value provided by the user.  Sets the host default value to 'http://localhost' but allows the user to overwrite. (DSheirer#1582)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1563 Updates RSP tuner to produce sample buffers with optimal power-of-2 length to enable downstream vectorized operations. (DSheirer#1583)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1584 Updates DMR & P25 decoders to stop processing residual samples from the current buffer after a traffic channel shutdown has been signalled. (DSheirer#1585)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1590 Resolves issue with RSP tuners generating too many native buffers causing excessive memory consumption (DSheirer#1591)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1588 Use JDK20 and Gradle 8.2.  Updates SDRPlay API for compatibility with JDK20 Project Panama Foreign Memory/Function changes. (DSheirer#1589)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* DSheirer#1586 Resolves issue in P25 message framer where after transmitting the current message the mDataUnitId is set to null and this causes an NPE when subsequent code is executed prior to shutdown of the channel. (DSheirer#1593)

Co-authored-by: Dennis Sheirer <dsheirer@github.com>

* Adds event type as a filtering option in the Events tab

* DSheirer#1368 Restructures Message and Event filter framework.

* DSheirer#1603 Resolves issue with de-duplicating events to allow call duration values to display correctly and minimize the quantity of duplicate events.

* DSheirer#1604 Resolves issue with event panel UI layout creating excess space between history management panel and events table.

* DSheirer#1605 Resolves issue where certain Linux users were unable to display the tuner editor panel due to an issue with the frequency control editor's usage of custom cursor.

* DSheirer#1612 Enhance aliasing to support DCS tones

---------

Co-authored-by: Denny Sheirer <dennissheirer2002@yahoo.com>
Co-authored-by: Dennis Sheirer <dsheirer@github.com>
Co-authored-by: wedgef5 <wedgef5@users.noreply.github.com>
Co-authored-by: Matthew Foster <matthew.foster@noaa.gov>
Co-authored-by: Nokoa <Nokoa@users.noreply.github.com>
Co-authored-by: sheirerd <sheirerd@ainfosec.com>
Co-authored-by: Christopher Varner <rdhddood@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DSheirer DSheirer

Labels
enhancement low
Projects
None yet
Milestone
Version 0.6.0
Development

Successfully merging a pull request may close this issue.

#35 AM & NBFM Adaptive Squelch & AM Decoder Enhancements DSheirer/sdrtrunk
2 participants
@DSheirer @ah1102