Skip to content

Commit

Permalink
DS-2672 Typos in constants in DOIIdentifierProvider
Browse files Browse the repository at this point in the history
  • Loading branch information
jonas-atmire authored and bram-atmire committed Aug 3, 2015
1 parent 5adc569 commit 4020f94
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

import java.sql.SQLException;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.DCValue;
Expand Down Expand Up @@ -68,12 +67,12 @@ public class DOIIdentifierProvider
public static final String DOI_QUALIFIER = "uri";

public static final Integer TO_BE_REGISTERED = 1;
public static final Integer TO_BE_RESERVERED = 2;
public static final Integer TO_BE_RESERVED = 2;
public static final Integer IS_REGISTERED = 3;
public static final Integer IS_RESERVED = 4;
public static final Integer UPDATE_RESERVERED = 5;
public static final Integer UPDATE_RESERVED = 5;
public static final Integer UPDATE_REGISTERED = 6;
public static final Integer UPDATE_BEFORE_REGISTERATION = 7;
public static final Integer UPDATE_BEFORE_REGISTRATION = 7;
public static final Integer TO_BE_DELETED = 8;
public static final Integer DELETED = 9;

Expand Down Expand Up @@ -251,7 +250,7 @@ public void reserve(Context context, DSpaceObject dso, String identifier)
return;
}

doiRow.setColumn("status", TO_BE_RESERVERED);
doiRow.setColumn("status", TO_BE_RESERVED);
try
{
DatabaseManager.update(context, doiRow);
Expand Down Expand Up @@ -352,11 +351,11 @@ public void updateMetadata(Context context, DSpaceObject dso, String identifier)
}
else if (TO_BE_REGISTERED == doiRow.getIntColumn("status"))
{
doiRow.setColumn("status", UPDATE_BEFORE_REGISTERATION);
doiRow.setColumn("status", UPDATE_BEFORE_REGISTRATION);
}
else if (IS_RESERVED == doiRow.getIntColumn("status"))
{
doiRow.setColumn("status", UPDATE_RESERVERED);
doiRow.setColumn("status", UPDATE_RESERVED);
}
else
{
Expand Down Expand Up @@ -415,11 +414,11 @@ public void updateMetadataOnline(Context context, DSpaceObject dso, String ident
{
doiRow.setColumn("status", IS_REGISTERED);
}
else if (UPDATE_BEFORE_REGISTERATION == doiRow.getIntColumn("status"))
else if (UPDATE_BEFORE_REGISTRATION == doiRow.getIntColumn("status"))
{
doiRow.setColumn("status", TO_BE_REGISTERED);
}
else if (UPDATE_RESERVERED == doiRow.getIntColumn("status"))
else if (UPDATE_RESERVED == doiRow.getIntColumn("status"))
{
doiRow.setColumn("status", IS_RESERVED);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -179,19 +179,19 @@ public static void runCLI(Context context, DOIOrganiser organiser, String[] args

if (line.hasOption('l'))
{
organiser.list("reservation", null, null, DOIIdentifierProvider.TO_BE_RESERVERED);
organiser.list("reservation", null, null, DOIIdentifierProvider.TO_BE_RESERVED);
organiser.list("registration", null, null, DOIIdentifierProvider.TO_BE_REGISTERED);
organiser.list("update", null, null,
DOIIdentifierProvider.UPDATE_BEFORE_REGISTERATION,
DOIIdentifierProvider.UPDATE_BEFORE_REGISTRATION,
DOIIdentifierProvider.UPDATE_REGISTERED,
DOIIdentifierProvider.UPDATE_RESERVERED);
DOIIdentifierProvider.UPDATE_RESERVED);
organiser.list("deletion", null, null, DOIIdentifierProvider.TO_BE_DELETED);
}

if (line.hasOption('s'))
{
TableRowIterator it = organiser
.getDOIsByStatus(DOIIdentifierProvider.TO_BE_RESERVERED);
.getDOIsByStatus(DOIIdentifierProvider.TO_BE_RESERVED);

try {
if (!it.hasNext())
Expand Down Expand Up @@ -244,8 +244,8 @@ public static void runCLI(Context context, DOIOrganiser organiser, String[] args
if (line.hasOption('u'))
{
TableRowIterator it = organiser.getDOIsByStatus(
DOIIdentifierProvider.UPDATE_BEFORE_REGISTERATION,
DOIIdentifierProvider.UPDATE_RESERVERED,
DOIIdentifierProvider.UPDATE_BEFORE_REGISTRATION,
DOIIdentifierProvider.UPDATE_RESERVED,
DOIIdentifierProvider.UPDATE_REGISTERED);

try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ public void testReserve_DOI()
assumeNotNull(doiRow);

assertTrue("Reservation of DOI did not set the corret DOI status.",
DOIIdentifierProvider.TO_BE_RESERVERED.intValue() == doiRow.getIntColumn("status"));
DOIIdentifierProvider.TO_BE_RESERVED.intValue() == doiRow.getIntColumn("status"));
}

@Test
Expand Down

0 comments on commit 4020f94

Please sign in to comment.