Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(6.x) S3 Bitstream implementation doesn't allow for alternate or self-hosted S3 services #8135

Closed
wants to merge 7 commits into from

Conversation

alejandratenorio
Copy link

References

Add references/links to any related issues or PRs. These may include:

Description

With this code, DSpace supports Amazon S3 storage as others S3 compatible storage (such as Storj, wasabi s3 and many more) for uploaded files.

Instructions for Reviewers

You just need to register in some S3 compatible storage, configure your awsEndPoint and your Security credentials in DSpace.

Thank you very much @Gerafp

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

@alejandratenorio alejandratenorio changed the base branch from main to dspace-6_x January 26, 2022 19:57
@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2022

This pull request introduces 3 alerts when merging dc9f111 into 7af52a0 - view on LGTM.com

new alerts:

  • 2 for Boxed variable is never null
  • 1 for Array index out of bounds

@tdonohue tdonohue added backend: bitstore Related to file/bitstream storage improvement labels Jan 26, 2022
@tdonohue tdonohue added the port to main This PR needs to be ported to `main` branch for the next major release label Jan 26, 2022
@tdonohue tdonohue changed the title S3 Bitstream implementation doesn't allow for alternate or self-hosted S3 services (6.x) S3 Bitstream implementation doesn't allow for alternate or self-hosted S3 services Jan 26, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2022

This pull request introduces 1 alert when merging 8353f65 into 7af52a0 - view on LGTM.com

new alerts:

  • 1 for Array index out of bounds

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2022

This pull request fixes 3 alerts when merging 4726c37 into 7af52a0 - view on LGTM.com

fixed alerts:

  • 3 for Array index out of bounds

@github-actions github-actions bot added the merge conflict PR has a merge conflict that needs resolution label Jul 27, 2022
@tdonohue tdonohue removed the port to main This PR needs to be ported to `main` branch for the next major release label Aug 28, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: bitstore Related to file/bitstream storage improvement merge conflict PR has a merge conflict that needs resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 Bitstream implementation doesn't allow for alternate or self-hosted S3 services
2 participants