DS-2452: Upgrade to Commons Pool v2 #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in a few Flyway related classes.
|
+1 by inspection. |
|
Reviewed and approved in today's DevMtg. Merging |
tdonohue
added a commit
that referenced
this pull request
Sep 23, 2015
DS-2452: Upgrade to Commons Pool v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the following tickets:
Also a followup to #1067
This PR ensures we are upgraded to the latest version of Apache Commons Pool 2 (since #1067 previously upgraded us to Apache Commons DBCP 2, which uses Pool 2). It performs a refactor of
EventServiceImplto use Pool v2 instead of Pool v1. The refactor was performed based on the migration notes at: https://commons.apache.org/proper/commons-pool/I've only performed some basic tests, and it looks like our event handler is still working after the refactor to Pool v2.
(Note: This was built off a branch that also includes #1070, as it involves tweaks to a few of the same maven POMs. Please consider merging #1070 first.)