DS-3122: Make DataCite XML namespace configurable. #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 by inspection |
|
rebased. |
|
+1 by inspection, and it is small and obvious. |
4science-it
pushed a commit
to 4Science/DSpace
that referenced
this pull request
Nov 24, 2023
CST-12744 if Announce received, NotifyRequestsStatus won't give the element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.duraspace.org/browse/DS-3122
This must be merged after #1197 as it already uses the schema version 3.
I don't think this really needs to be tested as the code change are so small an obvious. Just in case a short description on how to test this: take the XSLT from #1197, configure DSpace to mint DOIs with DataCite (see DSpace documentation), publish an Item and run [dspace-install]/bin/dspace doi-organiser -u. If it tells you that it successfully updated a DOI everything is fine.