DS-3435 possible nullpointerexception at AccessStepUtil$populateEmbar… #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…goDetail Conflicts: dspace-xmlui/src/main/java/org/dspace/app/xmlui/aspect/submission/submit/AccessStepUtil.java
|
also committed to master: |
mwoodiupui
reviewed
Jan 4, 2017
|
@samuelcambien can you recreate the branch or update it, in order to kick off travis again? Travis doesn't seem to complete the build/test here, and it's not clear why. |
|
The fix has been verified by this user: https://groups.google.com/forum/#!topic/dspace-tech/XYgOSbAtUHE |
|
I'm going to consider this approved, even though Travis stalled on us. It's been verified by a user, and it's identical to #1599. Merging |
4science-it
pushed a commit
to 4Science/DSpace
that referenced
this pull request
Jan 29, 2024
Add in-collection item filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DS-3435: possible nullpointerexception at AccessStepUtil$populateEmbargoDetail (line 250)
The ResourcePolicy$getGroup method documentation states the policy group can be null (which is correct, since the policy can also be defined for a specific eperson), but AccessStepUtil seems to assume it won't be null.
Also, the documentation for ResourcePolicy$getGroup needs to be updated, it mentions group id but the group object is returned instead. Same for setGroup.