Dspace 6 ds 3545 mirage2: custom sitemap.xmap is ignored

[samuelcambien]

Fixes #6895

There are two resources plugins:

• one for the local customizations (outside the maven-iterator-plugin)
• one for the dspace source files (inside the maven-iterator-plugin)

The first one is ran first, afterwards the other one runs.
The property 'overwrite=false' should avoid that local customizations would be overwritten by dspace source files.
But the property 'filtering=true' causes maven to ignore the overwrite property.
So the sitemap (the only file that will be filtered) will always be overwritten by the dspace original!

To fix this, I also moved the local customizations resources-plugin to inside the maven-iterator-plugin.
This is necessary anyway, because to filter a sitemap, the name of the theme directory is needed for the ${theme-path} and ${theme-name} variables.
I put it after the resources-plugin for the dspace source, and gave it 'overwrite=true'.
So the order is now reversed: first the source files are processed, and then overwritten by any local customizations.

I also made the split between files to filter and files not to filter consistent accross the two resources plugins: only filter the sitemap.
(instead of filtering everything, except a list of image extensions)

[samuelcambien]

also committed this to

dspace-5_x
#1691

master
#1689

[hardyoyo]

I'm not sure why Travis-CI testing of this PR has stalled, I can't find it anywhere in the Travis-CI logs for pull requests. I think our only option is to temporarily close then re-open this PR, which I'm willing to do, but I figured I'd mention it here before I try. Another option is to rebase this PR on upstream dspace-6_x, which isn't required, but would force Travis-CI to re-run tests. @samuelcambien it's up to you, would you prefer to rebase this pull request, or close & reopen it? Either alternative will force Travis-CI to rebuild, and if Travis-CI gives this PR a green light, that ought to be enough of a test to approve this.

[hardyoyo]

This PR looks good, though, and should be easy to test, since it's just a change to the build.

[samuelcambien]

Hi hardyoyo, thanks for the advice!
I rebased the pull request, looks like this put Travis-Cl to action..