DS-3914: Fix community defiliation #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2018 18:16
This fixes in issue in the defiliate method of the community filiator. The child and parent relations should be managed using the provided methods of the Community. This changes the visibility of Community.removeSubCommunity() to public, but Community.removeParentCommunity() was public before already.
This removes the loops for checking if a community is contained in a list of communities. Community.equals() does the same check, so we simply can use contains().
pnbecker
approved these changes
Sep 5, 2018
terrywbrady
added
the
port to main
terrywbrady
approved these changes
Dec 7, 2018
|
@AlexanderS , thanks for the fix. Could you port this to master? |
|
@terrywbrady Sure, see #2284. |
tdonohue
removed
the
port to main
|
Hello everyone. I modified the files CommunityFiliator.java and Community.java inmy dspace 6.3, then compiled with "mvn -U clean package" and "ant update" but the command ./dspace community-filiator -r -p [] -c [] still shows the message: Please could you help me? Kind regards, |
juliapim
pushed a commit
to juliapim/DSpace-1
that referenced
this pull request
Dec 9, 2020
DS-3914: Fix community defiliation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative for #2063 without changing the
CommunityService.removeSubcommunity()method.This fixes in issue in the defiliate method of the community filiator. The
child and parent relations should be managed using the provided methods of the
Community.
This changes the visibility of
Community.removeSubCommunity()to public, butCommunity.removeParentCommunity()was public before already. So this shouldnot be a problem.
The second commit is just a bit cleanup of manual loops.