DS-3914: Fix community defiliation (master) #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2018 11:19
This fixes in issue in the defiliate method of the community filiator. The child and parent relations should be managed using the provided methods of the Community. This changes the visibility of Community.removeSubCommunity() to public, but Community.removeParentCommunity() was public before already.
This removes the loops for checking if a community is contained in a list of communities. Community.equals() does the same check, so we simply can use contains().
tdonohue
approved these changes
Dec 7, 2018
There was a problem hiding this comment.
👍 Verified the code looks good and is identical to the changes in #2178 (which was already approved & merged). Thanks @AlexanderS for the port to master!
|
Merging immediately, as this is an exact port of code verified in 6.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #2178 ported to master.