[DS-4486] Tests for the Comm/Coll admins group edits #2770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… regards to the Admin groups
KevinVdV
added
the
quick win
4 tasks
| } | ||
|
|
||
| @Test | ||
| public void communityAdminAddMembersToCommunityAdminGroupSuccess() throws Exception { |
There was a problem hiding this comment.
| } | ||
|
|
||
| @Test | ||
| public void communityAdminRemoveMembersFromCommunityAdminGroupSuccess() throws Exception { |
There was a problem hiding this comment.
| } | ||
|
|
||
| @Test | ||
| public void communityAdminAddChildGroupToCommunityAdminGroupSuccess() throws Exception { |
There was a problem hiding this comment.
| } | ||
|
|
||
| @Test | ||
| public void communityAdminRemoveChildGroupFromCommunityAdminGroupSuccess() throws Exception { |
There was a problem hiding this comment.
|
|
||
|
|
||
| @Test | ||
| public void communityAdminAddMembersToCollectionAdminGroupSuccess() throws Exception { |
There was a problem hiding this comment.
I will rename my test to communityAdminCanManageCollectionSubmittersGroupAndAdminsGroupsTest and add
this test inside my test
| } | ||
|
|
||
| @Test | ||
| public void communityAdminRemoveMembersFromCollectionAdminGroupSuccess() throws Exception { |
There was a problem hiding this comment.
|
|
||
|
|
||
| @Test | ||
| public void collectionAdminAddMembersToCollectionAdminGroupSuccess() throws Exception { |
There was a problem hiding this comment.
Micheleboychuk
pushed a commit
to Micheleboychuk/DSpace
that referenced
this pull request
May 29, 2020
|
hi @KevinVdV |
|
Closing this PR as it has be integrated into #2774. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
This PR includes tests for the edits of the community / collection roles by community / collection admin.
This PR does NOT include a fix where community/collection admins can search for groups/epeople to add.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
400 Bad Request,401 Unauthorized,403 Forbidden,404 Not Found, etc)pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.