Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-1483 Generate citation_pdf_url in more cases #379

Merged
merged 1 commit into from
Nov 25, 2013

Conversation

aschweer
Copy link
Member

@aschweer aschweer commented Nov 6, 2013

Google Scholar uses the citation_pdf_url header tag on item pages to determine
which of an item's bitstreams to link to (if any). Standard DSpace behaviour is
to include this link only if the item has exactly one bitstream in the ORIGINAL
bundle and if this item is of type application/pdf. The desired behaviour for
the LCoNZ IRRs is this:

  • if the item has only one bitstream in the ORIGINAL bundle, link to this one
  • if the item has a primary bitstream in the ORIGINAL bundle, link to this one
    (regardless of how many bitstreams there are in total in the ORIGINAL bundle).
    Additionally, the bitstream link should only appear when the bitstream selected
    according to the rules above is publicly visible.
    The mimetype of the bitstream is not taken into account, as per Google Scholar
    feedback that this is no longer as important to them.

@tdonohue
Copy link
Member

tdonohue commented Nov 6, 2013

One quick note, @aschweer

Can you add the associated JIRA ticket id (DS-1483) to this PR? I'm unsure what the "#1887" refers to (as this ticket number doesn't exist in DuraSpace JIRA).

Beyond that, I'd love to see this get into 4.0. Need to test it myself still.

@aschweer
Copy link
Member Author

aschweer commented Nov 6, 2013

Oops good point @tdonohue -- it still had the issue number from our internal tracker on it. Fixed.

Google Scholar uses the citation_pdf_url header tag on item pages to determine
which of an item's bitstreams to link to (if any). Standard DSpace behaviour is
to include this link only if the item has exactly one bitstream in the ORIGINAL
bundle and if this item is of type application/pdf. The desired behaviour for
the LCoNZ IRRs is this:
 - if the item has only one bitstream in the ORIGINAL bundle, link to this one
 - if the item has a primary bitstream in the ORIGINAL bundle, link to this one
   (regardless of how many bitstreams there are in total in the ORIGINAL bundle).
Additionally, the bitstream link should only appear when the bitstream selected
according to the rules above is publicly visible.
The mimetype of the bitstream is not taken into account, as per Google Scholar
feedback that this is no longer as important to them.
@aschweer
Copy link
Member Author

aschweer commented Nov 6, 2013

Just a note that I ended up force-pushing so that the Jira ticket id is on the actual commit as well. I hope this doesn't cause problems for anyone.

mwoodiupui added a commit that referenced this pull request Nov 25, 2013
DS-1483 Generate citation_pdf_url in more cases
@mwoodiupui mwoodiupui merged commit 753d2a4 into DSpace:master Nov 25, 2013
artlowel referenced this pull request in atmire/DSpace Jun 13, 2014
DS-1483 Generate citation_pdf_url in more cases
alanorth added a commit to alanorth/DSpace that referenced this pull request Jun 5, 2018
input-forms.xml: Add CCAFS Phase II Project Tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants