Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-2441 Add a bitstream column to item/browse list #856

Closed
wants to merge 2 commits into from

Conversation

pastleo
Copy link

@pastleo pastleo commented Feb 4, 2015

https://jira.duraspace.org/browse/DS-2441

In the IR of our university, not all items have file (full text like pdf or we call 全文) , just some of them.
We want a function to show if there is a file in the item at the list view so I write (or maybe hack) some code into the core of dspace.
My code may not be great, but at least this will work.
If someone want this function too, they can add 'bitstream' to webui.itemlist.columns like line 1845 in dspace.cfg and the full version (with the file name and its link) can be enabled by webui.browse.bitstream.showfull = true on line 994 in dspace.cfg

@helix84 helix84 added this to the 6.0 milestone Feb 4, 2015
@helix84 helix84 changed the title Add a bitstream column to item/browse list DS-2441 Add a bitstream column to item/browse list Feb 4, 2015
@helix84
Copy link
Member

helix84 commented Feb 4, 2015

  1. Thank you for your contribution. Please, fix the compile error. https://travis-ci.org/DSpace/DSpace/builds/49433221
    Then either push a new commit to this branch (NCHUIR:master) or replace the branch (using push with the --force parameter).

  2. We keep track of issues in our Jira and all pull requests muse be accompanied by an issue. I created one here: https://jira.duraspace.org/browse/DS-2441

  3. Please note that we now require at least basic documentation for new features. You could use this template as a start: https://wiki.duraspace.org/display/DSDOC/New+Contribution+Template

  4. If you plan to submit multiple pull requests, it's possible to do so if you push your work to separate branches in your GitHub fork, e.g. NCHUIR:feature-1 and NCHUIR:feature-2 instead of NCHUIR:master.

@kstamatis
Copy link
Member

@helix84
Copy link
Member

helix84 commented Feb 4, 2015

There is new functionality in DSpace 5 JSPUI that sounds like a superset of what you're trying to implement here. Could you please look at it (links below), try it, and write whether you're trying to implement something different or whether you could use that existing functionality instead? Thanks.

https://jira.duraspace.org/browse/DS-2162
https://wiki.duraspace.org/display/DSDOC5x/Configuration+Reference#ConfigurationReference-JSPUI:Peritemvisualindicatorsforbrowseandsearchresults

@pastleo
Copy link
Author

pastleo commented Feb 5, 2015

First, sorry for the compile error. I directly apply our changes on 4.1.2 CRIS into your code...
After reading the doc, I think the functionality you mentioned is exactly what we want, sorry again for not searching in current version first. I will close this pull request
The only concern I have is if the performance might be a little bit affected by the each-item-query. Maybe we can add something like ItemMarkingDataPrepare interface to obtain the data for getItemMarkingInfo first? Or I just think too much? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants