Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users before executing an automatic change of context #3094

Closed
hostle83 opened this issue May 30, 2024 · 2 comments · Fixed by #3236
Closed

Warn users before executing an automatic change of context #3094

hostle83 opened this issue May 30, 2024 · 2 comments · Fixed by #3236
Assignees
Labels
accessibility affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug claimed: 4Science 4Science team is working on this issue & will contribute back component: Discovery related to discovery search or browse system e/6 Estimate in hours funded Task is funded via the DSpace Development Fund
Milestone

Comments

@hostle83
Copy link

hostle83 commented May 30, 2024

Describe the bug
According to WCAG 2 Success Criterion: 3.2.2 On Input (A), users should be warned before a change of context occurs on a site. As an example, when searching (https://sandbox.dspace.org/search?query=), use of the slider functionality in the Date filter reloads the page without giving the user a warning of that change or giving them the option to activate the reload themselves. See https://www.w3.org/WAI/WCAG21/Understanding/on-input.html for reference.

image

This behavior is consistent across all search filters.

To Reproduce
Steps to reproduce the behavior:

  1. Visit the search page on the sandbox, demo, or localhost (.../search?query=)
  2. Expand any search filter
  3. Adjust the search by using any filter, such as using the date slider to filter search results --> page reloads each time slider is used; the same holds true for all other search filters

Expected behavior
Either warn the user of the change of context (reload) beforehand, or give the user to activate the change themselves by providing a button or similar functionality

@hostle83 hostle83 added bug needs triage New issue needs triage and/or scheduling labels May 30, 2024
@tdonohue tdonohue added accessibility component: Discovery related to discovery search or browse system and removed needs triage New issue needs triage and/or scheduling labels May 30, 2024
@atarix83
Copy link
Contributor

atarix83 commented Jul 1, 2024

@tdonohue @hostle83

4science is interested in working on this task.
In order to fix the problem we'd add an additional button to apply the date range filter. Estimation is about 6h

@tdonohue tdonohue added the e/6 Estimate in hours label Jul 1, 2024
@tdonohue tdonohue added funded Task is funded via the DSpace Development Fund claimed: 4Science 4Science team is working on this issue & will contribute back labels Jul 1, 2024
@alanorth alanorth added affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases affects: 7.x Issue impacts 7.x releases labels Aug 7, 2024
@tdonohue tdonohue added this to the 7.6.3 milestone Aug 9, 2024
@tdonohue
Copy link
Member

tdonohue commented Aug 9, 2024

Closing as fixed by #3236. Ported to 8.x and 7.6.x.

@tdonohue tdonohue closed this as completed Aug 9, 2024
tdonohue added a commit that referenced this issue Aug 9, 2024
[Port dspace-7_x] #3094 - Update date slider to prevent automatic page reloads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug claimed: 4Science 4Science team is working on this issue & will contribute back component: Discovery related to discovery search or browse system e/6 Estimate in hours funded Task is funded via the DSpace Development Fund
Projects
Development

Successfully merging a pull request may close this issue.

4 participants