New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
150 list and grid feedback #202
150 list and grid feedback #202
Conversation
…id/list specific implementations
3af7aec
to
02e6c89
Compare
@jonas-atmire : This is currently showing build errors in Travis: https://travis-ci.org/DSpace/dspace-angular/jobs/309526382#L4099 |
…id/list specific implementations
@tdonohue looking at the travis build output, those errors don't seem to be caused by this PR, they're in files that aren't affected by this PR. I think that #207 and #208 made the travis rules stricter and more likely to fail, and this PR is the first one to use them so it fails on errors that were already there. In any case, those errors prevent the actual tests on this PR from even running, so they should still be fixed before the PR can be reviewed. |
… 150-List-and-grid-feedback
The initial failure of the build(/test) was my doing. This broke the spec-bundle.js imports. The tests are now running, but some additional non-pr related tests still show some errors (that do not break the actual test run). |
I finally got around to testing this today. Overall, it works well (thanks @jonas-atmire!). However, I did notice two issues in my tests:
Beyond those two minor issues, this seems to work well. |
|
@artlowel : It's quite off putting to see that change occur automatically when switching back and forth, but I understand better now. I just wonder if we should auto-switch back to 10 when you move back to "list view" (since obviously it's auto-switching to 12 when you move to grid view). |
@tdonohue yes, it should definitely auto-switch back. If it doesn't that's a bug |
Currently, the pagination on the grid view has been fixed. Another thing that has to be fixed is the following. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Retested this today, and it works great now. Both issues I previously found have been resolved.
This PR connects to #150
It uses the ViewMode to switch between displaying "list" and "grid"
(Currently, only the pre-existing viewmode switcher on the search page is used)
Additionally, this also moves some packages to the "shared" module instead of directly under the app directory