Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Travis using headless Chrome addon #207

Merged
merged 1 commit into from Nov 29, 2017
Merged

Run Travis using headless Chrome addon #207

merged 1 commit into from Nov 29, 2017

Conversation

courtneypattison
Copy link
Contributor

Fixes #206

  • Replaced apt addon with chrome addon
  • Removed yarn run lint because it always returns 0 and it is in yarn run ci
  • Moved yarn run build to script because the Travis docs say you run the build script there
  • Removed Xvfb
  • Removed custom Chrome launcher for Travis
  • Created a script for running karma tests with ChromeHeadless
  • Updated protractor config to use headless Chrome

I'm not sure how to test this, so it may fail miserably.

@ghost ghost added the needs review label Nov 29, 2017
@ghost
Copy link

ghost commented Nov 29, 2017

+1

@tdonohue tdonohue mentioned this pull request Nov 29, 2017
Closed
@artlowel
Copy link
Member

LGTM

@artlowel artlowel merged commit b906fb2 into DSpace:master Nov 29, 2017
@ghost ghost removed the needs review label Nov 29, 2017
@artlowel artlowel mentioned this pull request Dec 1, 2017
Merged
@courtneypattison courtneypattison deleted the travis-headless-chrome branch December 19, 2018 23:08
@tdonohue tdonohue added this to the 7.0preview milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@courtneypattison courtneypattison

Labels
None yet
Projects
None yet
Milestone
7.0preview
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@courtneypattison @artlowel @tdonohue