Get requests fail second time #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2018 11:05
…onse arrived, preventing them from being executed again after the cache timed out
ghost
assigned 
|
I've tried the changes, new requests are executed, but I've noted an odd behavior. I also observed that In a RemoteData object returned, the value of |
artlowel
changed the title
|
closing in favour of #367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #216
The reason for the issue was that the request pending status was never removed after a request was completed, due to a mistake in the switch from hrefs to uuids as identifiers for requests. Subsequent requests for the same URL (after something had been removed from the cache) wouldn't be executed because the request seemed to be already pending
This PR contains a test for the issue, and a fix.