Admin pop-up to create/edit a DSO #367

LotteHofstede · 2019-03-07T15:05:55Z

This PR adds the ability to quickly go to a create or edit page as an administrator, using the admin menu.
To use this functionality, login and click a Community/Collection/Item menu item in the New or Edit menu section.

Create

For Communities a list of Communities will be shown in which you can create a subcommunity - or you can choose to add a new Top-level community instead.
For Collections a list of Communities will also be shown in which you can create a the collection.
For Items a list of Collections will be shown in which you can create a new Item.*

Edit:

For edit a list of the respective object type is shown.

*) These create item links do not work yet, because there's no direct link (even in the submission PR) to submit an item in a specific collection

Note that in the mockups, a list of parents was shown for the communities/collections like a trail.
However, this functionality is not yet implemented yet because DSpace objects do not have any parents in the backend yet. This relates to this comment on the Submission PR

This PR now also closes #219

Conflicts: src/app/shared/shared.module.ts

tdonohue

Honestly, this looks great overall. I've tested it, and it works. I'm nearly a 👍 , but I have a few (very minor) requests for TypeDocs, comments etc. inline below.

tdonohue · 2019-03-08T22:15:55Z

src/app/+admin/admin-sidebar/admin-sidebar.component.ts

+          function: () => {
+            this.modalService.open(CreateCommunityParentSelectorComponent);
+          }
+        } as OnClickMenuItemModel,


Strangely, even though Create Community is listed first in this component, it shows up last under the "New" menu. I'm not sure that's a fault of this PR though.

Strangely enough, this behaviour only occurs when preboot is enabled and is not related to this PR.
I'm not sure why this happens, but before launching the Admin Menu PR I discussed this with @artlowel and we decided it's not really a bug: if you want to force a specific order of menu items, you can explicitly pass a manual "index" when creating a new menu item.

I agree this isn't the fault of this PR. I see the same behavior on master.

However, I'm going to log it as a bug, as I feel these menus should retain an expected ordering. At the very least, we need to document the "force a specific order of menu items" option you noted, but ideally we should find a way to get ordering to remain consistent.

Nonetheless, it's a bug not caused by this PR. So, this PR can obviously move forward as-is.

src/app/+search-page/search-page.module.ts

...al-wrappers/create-collection-parent-selector/create-collection-parent-selector.component.ts

...odal-wrappers/create-community-parent-selector/create-community-parent-selector.component.ts

...selector/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component.ts

src/app/shared/dso-selector/modal-wrappers/dso-selector-modal-wrapper.component.ts

...d/dso-selector/modal-wrappers/edit-collection-selector/edit-collection-selector.component.ts

...red/dso-selector/modal-wrappers/edit-community-selector/edit-community-selector.component.ts

src/app/shared/dso-selector/modal-wrappers/edit-item-selector/edit-item-selector.component.ts

tdonohue

👍 Gave this a second review/test. It looks great to me now. Thanks @LotteHofstede !

paulo-graca · 2019-03-12T14:58:42Z

I'm having a weird behavior. A UUID is showed just after creating a new Top Level community and I can't do anything (create a sub-community or collection)

When I'm trying to create a new collection on a nearly created community, a UUID is showed and I can't create a collection:

paulo-graca · 2019-03-12T15:10:52Z

@LotteHofstede a doubt I have, "new item" is same as "submission", right? It will be created another PR to integrate this work with the submission?

LotteHofstede · 2019-03-14T11:00:20Z

@paulo-graca If I understand correctly, you create a Community which will redirect you to the detail page of that Community. Then you open the admin menu and try to create/edit another Community or create a Collection. Because you are on a community detail page, the current community's UUID will already be filled out to help you.

Unfortunately, this will give you 0 results, because the SOLR search core has not yet indexed the newly created community and therefore cannot find it yet. You should be able to find the Community if you wait a bit longer and search for the UUID again.

I understand this is confusing behaviour, but it's nothing we can do anything about in the frontend.
We could request to turn the backend's SOLR indexing delay off or minimise it, or at least force a SOLR commit after a new DSO is created.

Thanks to your report I did find another issue with request caching. The cache was almost never invalidated because of some bugs in the request service code. I did fix this, which should also fix issue #219.

To answer your second question: yes, the New item menu item should link to the submission page. I asked @atarix83 to look into creating a link to immediately submit a new item into an existing collection, however this is not yet available (neither is it in the current Submission PR, as far as I'm aware).

paulo-graca · 2019-03-18T18:10:51Z

When creating a new Item, I was trying to searched for an existing collection. I noticed that, for every typed letter, the service makes a request. After several typed letters I've got a 403 HTTP Error (Forbidden) when searching for that collection.
And after that error, the service stopped performing requests.
Console error:
ERROR TypeError: Cannot read property 'objects' of undefined
at MapSubscriber.project (search.service.ts:115)
at MapSubscriber../node_modules/rxjs/_esm5/internal/operators/map.js.MapSubscriber._next (map.js:35)
at MapSubscriber../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.next (Subscriber.js:54)
at MapSubscriber../node_modules/rxjs/_esm5/internal/operators/map.js.MapSubscriber._next (map.js:41)
at MapSubscriber../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.next (Subscriber.js:54)
at MapSubscriber../node_modules/rxjs/_esm5/internal/operators/map.js.MapSubscriber._next (map.js:41)
at MapSubscriber../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.next (Subscriber.js:54)
at FilterSubscriber../node_modules/rxjs/_esm5/internal/operators/filter.js.FilterSubscriber._next (filter.js:38)
at FilterSubscriber../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.next (Subscriber.js:54)
at SwitchMapSubscriber../node_modules/rxjs/_esm5/internal/operators/switchMap.js.SwitchMapSubscriber.notifyNext (switchMap.js:66)

… paginated lists

artlowel · 2019-03-19T15:35:25Z

@paulo-graca we weren't able to reproduce the 403, perhaps you can give more details about what you typed to get it? @LotteHofstede did adjust the search service to ensure an unexpected result can no longer break the UI for follow up queries. She also added a debounce to ensure that not every keypress gets sent to the server if you're typing quickly.

paulo-graca · 2019-03-19T18:50:37Z

@LotteHofstede did adjust the search service to ensure an unexpected result can no longer break the UI for follow up queries

That is great! I will perform another test.

paulo-graca

I performed another test and now it works properly, the code looks ok to me. @LotteHofstede thank you for your work!

tdonohue · 2019-03-21T13:45:46Z

This PR is now at +2. I gave it another quick code review (of more recent changes). Merging. Thanks @LotteHofstede!

LotteHofstede added 8 commits March 7, 2019 14:23

60113: context sensitive popup started from submission branch

bc305e2

refactored lookup

61a5620

implemented edit popups and added actions

9f02f65

fixed focus and css

b4d404e

refactored, started tests

9abbfa9

added tests for popups

31d2428

fixed metadata value issues

c60175a

fixed focus for first list result

56271c3

artlowel added the needs review label Mar 7, 2019

LotteHofstede added 2 commits March 8, 2019 08:51

fixed documentation

ede9f05

Merge branch 'master' into w2p-60113_admin-select-dso-modal

0a1138f

Conflicts: src/app/shared/shared.module.ts

tdonohue reviewed Mar 8, 2019

View reviewed changes

applied feedback

f1686f3

tdonohue approved these changes Mar 11, 2019

View reviewed changes

LotteHofstede added 4 commits March 13, 2019 15:51

fixed caching

88ae626

fixed tests after changes to request caching

4c15098

added missing tests and docs

917c00f

reinstated responseMsToLive for get requests

f160196

artlowel mentioned this pull request Mar 14, 2019

Get requests fail second time #219

Closed

Added debounce, fixed error handling for search results, fixed bug in…

6d64326

… paginated lists

paulo-graca approved these changes Mar 21, 2019

View reviewed changes

tdonohue merged commit 6aa0ec4 into DSpace:master Mar 21, 2019

ghost removed the needs review label Mar 21, 2019

tdonohue mentioned this pull request Mar 21, 2019

Submission implementation #279

Merged

tdonohue mentioned this pull request Apr 29, 2020

Issue with root endpoint response cache time to live #216

Open

benbosman deleted the Admin-select-DSO-modal branch September 11, 2020 07:44

tdonohue added this to the 7.0preview milestone Jan 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Admin pop-up to create/edit a DSO #367

Admin pop-up to create/edit a DSO #367

LotteHofstede commented Mar 7, 2019 •

edited

Loading

tdonohue left a comment

tdonohue Mar 8, 2019

LotteHofstede Mar 11, 2019

tdonohue Mar 11, 2019

tdonohue left a comment

paulo-graca commented Mar 12, 2019

paulo-graca commented Mar 12, 2019

LotteHofstede commented Mar 14, 2019 •

edited

Loading

paulo-graca commented Mar 18, 2019

artlowel commented Mar 19, 2019

paulo-graca commented Mar 19, 2019 •

edited

Loading

paulo-graca left a comment

tdonohue commented Mar 21, 2019

Admin pop-up to create/edit a DSO #367

Admin pop-up to create/edit a DSO #367

Conversation

LotteHofstede commented Mar 7, 2019 • edited Loading

Create

Edit:

tdonohue left a comment

Choose a reason for hiding this comment

tdonohue Mar 8, 2019

Choose a reason for hiding this comment

LotteHofstede Mar 11, 2019

Choose a reason for hiding this comment

tdonohue Mar 11, 2019

Choose a reason for hiding this comment

tdonohue left a comment

Choose a reason for hiding this comment

paulo-graca commented Mar 12, 2019

paulo-graca commented Mar 12, 2019

LotteHofstede commented Mar 14, 2019 • edited Loading

paulo-graca commented Mar 18, 2019

artlowel commented Mar 19, 2019

paulo-graca commented Mar 19, 2019 • edited Loading

paulo-graca left a comment

Choose a reason for hiding this comment

tdonohue commented Mar 21, 2019

LotteHofstede commented Mar 7, 2019 •

edited

Loading

LotteHofstede commented Mar 14, 2019 •

edited

Loading

paulo-graca commented Mar 19, 2019 •

edited

Loading