-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved test coverage and TypeDoc #380
Merged
tdonohue
merged 4 commits into
DSpace:master
from
atmire:improved-test-coverage-and-typedoc
Apr 15, 2019
Merged
Improved test coverage and TypeDoc #380
tdonohue
merged 4 commits into
DSpace:master
from
atmire:improved-test-coverage-and-typedoc
Apr 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
approved these changes
Apr 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me, and passes all tests. Thanks @LotteHofstede !
paulo-graca
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merging as this is at +2 |
kosarko
pushed a commit
to ufal/dspace-angular
that referenced
this pull request
Nov 8, 2023
* Added static files and redirection * Html content is loaded from the static file and rendered in the component. * The html file content is showed in the `static/` route with the error page. The translation works. * Created routing for the `licenses` page and changed administrator license table to `licenses/manage-table` path * Show all licenses data. * All licenses are filtered by license label - PUB, ACA, RES * Added loading bar * Added redirect from license selector * Fixed tests. * Refactoring * Fixed lint error - unused import * Added docs and translations. * Removed accidentally added semicolon. * Added simple test if the html file content will be loaded.
kosarko
pushed a commit
to ufal/dspace-angular
that referenced
this pull request
Jun 20, 2024
* Added static files and redirection * Html content is loaded from the static file and rendered in the component. * The html file content is showed in the `static/` route with the error page. The translation works. * Created routing for the `licenses` page and changed administrator license table to `licenses/manage-table` path * Show all licenses data. * All licenses are filtered by license label - PUB, ACA, RES * Added loading bar * Added redirect from license selector * Fixed tests. * Refactoring * Fixed lint error - unused import * Added docs and translations. * Removed accidentally added semicolon. * Added simple test if the html file content will be loaded.
kosarko
added a commit
to ufal/dspace-angular
that referenced
this pull request
Jun 25, 2024
* internal/complex-input-type-validation (#137) * Initial commit * Added maximum length in the complex input type. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * internal/search-page-fix-wrong-pr (#140) search-component: missing `clarin-search` * Initial commit * Added maximum length in the complex input type. * Added `clarin-search` component to the search-page --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * Search is working - it redirect (#142) Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * internal/downloading-bitstreams-by-license-not-work (#144) add email info * Fixed loading the license into selection and fixed assigning wrong license after choosing it. * Fixed sending an email with download link - added email input field. * Removed console log messages. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * enable debug of backend * internal/item-page-lookfeel (#147)changed item page * Trying to compose required information to the item page. * Raw version of the updated item-page. * Fixed ref-box when the item has more authors. * Removed unused files. * Removed logging to the console. * Export new component from the item-page.module * Refactoring - beautify the code * Removed disabled components from the item-page.module * Removed unuseful tests. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * fixed matomo container deployment * custom run (with debug enabled) for dspace container * internal/missing-search-page-paggination (#150) object-list component changed * Fixed search pagination. * Updated object-list was used by more components. Use CLARIN changes only in the search-page. It is separated by the config.id. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * internal/license-selector-not-assignee-license Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * migration2clarin7/unfinished-submissions-not-listed (#153) * Show ClarinItemBoxView only in searching, not in the /mydspace page * Updated tombstoned items based on the updated database model. * Updated loading of the dump for the integration tests. * Commented out failing test. * Changed test dump --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * migration2clarin7/fix-different-separator-in-crosswalks (#155) * Added validation for the complex input field * Commented out failing test. * Changed test dump --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * migration2clarin7/authors-name-surname-autocomplete (#161) * Created clarin-name input field * Suggestions for the author name are showed up * Show author input field which consist of autocomplete and input * Lastname autocomplete add a value into both input fields. * Fixed some graphic and easy issues, failing tests and refactoring * The input fields value wasn't filled in after selecting the option. * Uncomment commented integration tests * Little refactoring and added docs * Changed test dump * Changed IT expected values, just trying. * Changed IT just check it there is two input fields. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * migration2clarin7/license-dropdown-missing-labels-2 (#164) * Trying to create own component for selecting the Clarin License. * The dropdown select is scrollable. * Added default option. * Added searching for the license selector. * Maybe finally I've done that lovely license selector. * Fixed lint error after solving the conflicts. * Refactoring and added docs. * Beautified license selector. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * migration2clarin7/notice-step-is-missing (#159) * Added a new empty notice step. * Set up Notice Step body. * Created a test for the new step * Beautify code * Added integration tests for the Notice Step * Changed dump for test environment. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * 70-FE/license-page-missing-pagination-sorting (#166) * Fixed pagination and added a new search input field for better overview in the licenses. * Fixed tests * Fixed integration tests. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * 11-FE/after-login-show-discojuice (#170) * Make discojuice active on login button * When the user click on the `Local authentication` - redirect him to `/login` page. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * 66-FE/clickable-metadata-item-view (#168) * After clicking on the author the user is redirected into search page with current author. * Some fields are fixed * Added subject and some fields are fixed. * Added author metadata field, the clarin-author-preview component was created and added into clarin-item-box-view.component * Acknowledgement was overlaying the metadata value - fixed * Refacroting and added docs. * Refactored if --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk> * fix target so it matches dspace7 (#175) repoPath already contains hostname and port. use authn/shibboleth instead of shibboleth-login * 103-fe/shibboleth-login-wrong-error-page (#177) * Removed redirecting in the FE - redirecting is made in the BE. * Commented failing test. * Added todo into commented test. * 109-fe/license-label-icons-are-not-seen (#180) * Updated ClarinItemViewBox * Fixed NewHandleComponent tess * Removed unused imports * Fixed search redirection and license icons (#183) * Added encoding if the license name contains the plus character. (#185) * added erase database workflow * redeploy after erase database * Also restart other containers, not just db * Updated css colors. (#196) * 114-fe/cannot-download-item-with-restricted-license (#187) * The user is redirected to the license agreement page * ClarinAuthorization request must be completed * 122-fe/restricted-item-download-issues (#222) * Initial commit * The user metadata value couldn't be seen. * Updated unit test according to new changes. * Just updated the dump. (#224) * Internal/multideploy support (#238) * all done.. but will it work? * fix -p * added multiinstance support * moved to standard port 80 * fixed .env for deployment on dev-5 * use correct version for cli docker * added DSPACE_VER * remove automatic deploy * update erasing database * space issues * renames and redo deploy * redeploy always * set correct instance * correct message * further separation, better comments * get rid of space at end attempt 0 * erase trailing space attempt 1 * erase trailing space attempt 2 * erase trailing space attempt 3 * erase trailing space attempt 4 * fix correct branch in call after erase_db * add redeploy to dev-5 -> curl call to deploy action * forgotten " in github action * correct redeploy branch in github action * trigger docker images on correct branch * fix updated postgres image on docker hub (#256) * internal-7.2/add-cz-language (#271) * Added a czech translation * Updated menu navbar and added translations. * disable deploy on dev-5 on version 7.2 * disabled deploy on dev-5 of dspace v7.2 * Upgrade CLARIN-DSpace to 7.5 (#228) * Update recent-item-list.component.ts Update PaginatedSearchOptions to only retrieve items * 98863: Prevent retrieval of the domains on TYPE_REQUEST_FORGOT form & fixed error message when no emails are set * Refactor to two caches. One for bots and one for anonymous users * Fix test configuration * Add test for xsrf and change to Post so xsrf is tested for validity * collection is displayed below the submitter * [CST-7757] Remove subscription button from item pages * [CST-7757] Response parameters fixed; submit button disabled if frequency is missing * [CST-7757] D-W-M fixed * [CST-7757] Show object name * 98855: Remove temp themed ng-content container This is problematic when ng-content is provided but it's not used * [CST-7221] Opaque search bar * [CST-7757] Minor fixes * [CST-7757] Labels renamed * [CST-7755] updated PR to latest REST changes * 97298: Added form validator tests for restricted domains * 99053: Invalidate cache by default when performing the WorkflowItemActionPageComponent action * 99053: Added DeclinedTask search result banner * 99053: Fixed AdvancedWorkflowActionRatingComponent's rating from validation * 99053: Added missing documentation * [TLC-380] Support browse links and regex links in metadata display (resolved conflicts jan 2023) * [TLC-380] Lint fixes * [TLC-380] Lint fixes * [TLC-380] Unit test (provider injection) fixes (resolved conflict jan 16) * [TLC-380] lint fix * [TLC-380] further browse link unit test fixes (waitForAsync) * [TLC-380] Refactor browse links to use new /browses endpoint * [TLC-249] Fix circular dependency in browse services * [TLC-249] Larger refactor to field, item components for browse links * [TLC-249] Lint fixes * [TLC-249] Lint fixes * [TLC-380] Fix mock service to return proper payload * [TLC-380] Simplify / strip browse service from components * [TLC-380] Lint fixes for mock browse def service * [TLC-380] Template link, spec test, doc fixup as per review * [TLC-380] Refactor metadata rep list comp after rebase * [TLC-380] Lint fixes * [TLC-380] Template link fixes, spec test fixes Correct use of routerLink and queryParams Removed unused method from browse service, specs New spec tests for MetadataRepresentationListElementComponent * [TLC-380] Lint fixes on spec test * [TLC-380] Fix item page field test to supply router * [TLC-249] Show Identifier Step angular 7.x * [TLC-249] Remove CRIS7 visibility refs from component, i18n * [TLC-249] Lint fixes * [TLC-249] LGTM unused import fixes * [TLC-249] Register DOI operation and button in item status page * [TLC-249] Linting * [TLC-337] Unit tests for register DOI component * [TLC-249] Lint fixes * [TLC-249] Update data service usage since rebasing * [TLC-249] Update data service usage since rebasing * [TLC-249] Ensure identifier data model mapped to type * [TLC-249] Update spec test for new config form data service * [TLC-249] Addressing review feedback Adding comments and tidying some comments, imports Expect text for status not integer Send a 'type' parameter with a DOI registration Rename item-status.register to registerDOI As per todonohue's feedback on 2022-01-18 * [TLC-249] Addressing review feedback #2 Update WorkspaceitemSectionIdentifiersObject model to include a display types string array, so identifier types can be included or excluded from the step as needed. Update section template to work with the above new data As per todonohue's feedback on 2022-01-18 * [TLC-249] Lint fixes (imports, quotes) * [TLC-249] Improve model of identifier data in workspace section * [TLC-249] Update en.json5 with DOI status labels * [TLC-249] Identifier mock data updated in unit test * [TLC-249] Identifier mock data updated in unit test * [TLC-380] Renaming, changes as per review feedback * [TLC-380] WIP trying new routing / create flow * [TLC-380] Refactor to use new endpoints, better naming * [TLC-380] Refactor to use new endpoints, better naming * [TLC-249] Attempting art's sub fix (doesn't work) * [TLC-249] Update item status button logic to avoid nested subs * [TLC-249] Lint * [TLC-249] Fix import typo (from merge conflict) * [TLC-249] Further test fixes * Retrieve the XSRF token first, and set it as both the XSRF header and cookie * Fix direct CSR By moving from environment.ts to config.yml we made it so the environment is _not_ up to date with the server configuration when main.js is first loaded. Because of this the app behaved as if CSR always happened _after_ SSR, effectively breaking direct CSR. Here the "criterion" for SSR/non-SSR HTML is changed from the related configuration property to the presence of Angular Universal transfer state. This means we can correctly determine when to bootstrap the app for direct CSR, and it's' now "safe" to just send index.html by itself. * Fix lint and test issues * Add "debug" config and "allowStale" configs * Add done() to async tests * 99053: Added test to check that the TYPE_REQUEST_FORGOT doesn't use the authentication-password.domain.valid * 97732 Remove unnecessary subscriptions * [CST-7757] subscriptions data service tests * Fixed text (without HTML tags) not being passed to child components * Fixed default @Input() values not working for themed components * [CST-7757] subscription modal tests * [CST-7757] modal fixes * [CST-7757] modal fixes * [CST-7217] Add margins to better align badge * [CST-7757] Hide delete info for new subscriptions and fix issue with unavailable items * Keep SSL sessions alive between xhr2 requests * [CST-7755] added cancel button to modal and updated message returned when a supervision order already exists * [CST-7755] lint fix * Fix bug where allowStale couldn't be disabled * 99053: Removed ngx-bootstrap dependency * 99053: Fixed encoded parameters being encoded twice in WorkflowItemActionPageComponent.previousPage() * 99053: Passed previousSearchQuery to AdvancedWorkflowActionSelectReviewerComponent * 99053: Passed previousSearchQuery to AdvancedWorkflowActionSelectReviewerComponent * 99053: Pass all queryParameters to advanced workflow pages by default * 99053: Save queryParams in init to prevent them being overwritten * Bump http-cache-semantics from 4.1.0 to 4.1.1 Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](https://github.com/kornelski/http-cache-semantics/compare/v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * [CST-7755] WIP refactoring * [CST-7757] Missing label * fixed issue in browser console * [CST-7755] WIP revert changes on list components * [CST-7757] Fix delete message * [CST-7755] Complete refactoring * Fix for "cannot read properties of undefined" error * [CST-8914] Add flag to show/hide csv export button * src/assets/i18n: Improve English strings for file upload Simple improvement to the wording in the file upload section of the item submission form. Also add a period at the end of the string. Fixes: #2096 * [CST-8935] Fix issue with missing matcher providers * translation fixes in security form * remove minimum passwort length value from translated messages * fixed missing comma * added comma to default translation * suggestionOption.name displayed * [CST-8952] Fix issue with admin reset password functionality * avoiding console.log errors * Fix param to send user the forgot password email * Update version tag for release * Fixed a lot of compilation errors, but there is a need to refactor services. * Added yarn.lock * Fixed some service updates * Fixed some service updates * Solved some errors, but it is still not working. * Something starting to work - the problem is in loading the modules * Updated database testing dump for integration tests * Fixed unit tests * Fixed admin menu * Fixed lint issues * Fixed handle page circular dependency * Fixed AuthorNameLink circular dependency * Fixed compilation errors * Fixed failing Unit tests * Integration tests should take image `migrate-to-7.5` * Integration tests should take image `migrate-to-7.5` * revert docker-compose-ci.yml changes * Updated BE envs * Changed localhost to 127.0.0.1 * Added DSPACE_UI_HOST and DSPACE_UI_PORT to 127.0.0.1:4000 * Changed logging in the IT * Fixed login * Maybe fixed integration tests * Copied a new code from the actual dtq-dev * Fixed discojuice login pop up * added S3 config to docker-compose-rest.yml * Fixed IT * Integration tests should not fail on console log error. * Removed failing test what is not needed. * SUbmitter user changed to admin * Commenteed failing tests. * added values for S3 to cli.yml * Added flags into discojuice * Added flags into discojuice * Added another icons into discojuice * discoPath is cleared in the discojuice.js * Create migrate-docker.yml to create docker image * create tag migrate-to-7.5 * Fixed some shibboleth problems * Fixed problem during downloading restricted bitstreams. * Migrate to 7.5 (#174) * 97742: Add missing export * Make ThemedComponent reproject slots to wrapped component * [CST-7217] Implement short number pipe * 97425: Fix minor issues * Remove flex-wrap * 99053: Fixed previous page not always returning the correct value - Fixed previousPage not correctly redirecting to urls with queryParams - Fixed previousPage returning to wrong page because of ReviewersListComponent * 99053: Hide return to pool button for second step of SelectSingleReviewer * [CST-7217] Use short number pipe and fix badge alignment * Fix typo * Add SSR caching via lru-cache. Update Cache-Control header to 1 week, but tell browsers not to cache index.html * Update SSR caching to only work when unauthenticated. Enhance config comments * Add missing test configs * Updates to defaults of cache.control setting and enhanced comments * Remove unused import * Rename enableCache() to initCache() to make code easier to understand * Avoid caching a page twice in a row * adding role for ul and li i have added roles for ul and li (tablist and tab) * w2p-99039 Add xsrf token to createShortLivedToken get request * Update recent-item-list.component.ts Update PaginatedSearchOptions to only retrieve items * 98863: Prevent retrieval of the domains on TYPE_REQUEST_FORGOT form & fixed error message when no emails are set * Refactor to two caches. One for bots and one for anonymous users * Fix test configuration * Add test for xsrf and change to Post so xsrf is tested for validity * collection is displayed below the submitter * [CST-7757] Remove subscription button from item pages * [CST-7757] Response parameters fixed; submit button disabled if frequency is missing * [CST-7757] D-W-M fixed * [CST-7757] Show object name * 98855: Remove temp themed ng-content container This is problematic when ng-content is provided but it's not used * [CST-7221] Opaque search bar * [CST-7757] Minor fixes * [CST-7757] Labels renamed * [CST-7755] updated PR to latest REST changes * 97298: Added form validator tests for restricted domains * 99053: Invalidate cache by default when performing the WorkflowItemActionPageComponent action * 99053: Added DeclinedTask search result banner * 99053: Fixed AdvancedWorkflowActionRatingComponent's rating from validation * 99053: Added missing documentation * [TLC-380] Support browse links and regex links in metadata display (resolved conflicts jan 2023) * [TLC-380] Lint fixes * [TLC-380] Lint fixes * [TLC-380] Unit test (provider injection) fixes (resolved conflict jan 16) * [TLC-380] lint fix * [TLC-380] further browse link unit test fixes (waitForAsync) * [TLC-380] Refactor browse links to use new /browses endpoint * [TLC-249] Fix circular dependency in browse services * [TLC-249] Larger refactor to field, item components for browse links * [TLC-249] Lint fixes * [TLC-249] Lint fixes * [TLC-380] Fix mock service to return proper payload * [TLC-380] Simplify / strip browse service from components * [TLC-380] Lint fixes for mock browse def service * [TLC-380] Template link, spec test, doc fixup as per review * [TLC-380] Refactor metadata rep list comp after rebase * [TLC-380] Lint fixes * [TLC-380] Template link fixes, spec test fixes Correct use of routerLink and queryParams Removed unused method from browse service, specs New spec tests for MetadataRepresentationListElementComponent * [TLC-380] Lint fixes on spec test * [TLC-380] Fix item page field test to supply router * [TLC-249] Show Identifier Step angular 7.x * [TLC-249] Remove CRIS7 visibility refs from component, i18n * [TLC-249] Lint fixes * [TLC-249] LGTM unused import fixes * [TLC-249] Register DOI operation and button in item status page * [TLC-249] Linting * [TLC-337] Unit tests for register DOI component * [TLC-249] Lint fixes * [TLC-249] Update data service usage since rebasing * [TLC-249] Update data service usage since rebasing * [TLC-249] Ensure identifier data model mapped to type * [TLC-249] Update spec test for new config form data service * [TLC-249] Addressing review feedback Adding comments and tidying some comments, imports Expect text for status not integer Send a 'type' parameter with a DOI registration Rename item-status.register to registerDOI As per todonohue's feedback on 2022-01-18 * [TLC-249] Addressing review feedback #2 Update WorkspaceitemSectionIdentifiersObject model to include a display types string array, so identifier types can be included or excluded from the step as needed. Update section template to work with the above new data As per todonohue's feedback on 2022-01-18 * [TLC-249] Lint fixes (imports, quotes) * [TLC-249] Improve model of identifier data in workspace section * [TLC-249] Update en.json5 with DOI status labels * [TLC-249] Identifier mock data updated in unit test * [TLC-249] Identifier mock data updated in unit test * [TLC-380] Renaming, changes as per review feedback * [TLC-380] WIP trying new routing / create flow * [TLC-380] Refactor to use new endpoints, better naming * [TLC-380] Refactor to use new endpoints, better naming * [TLC-249] Attempting art's sub fix (doesn't work) * [TLC-249] Update item status button logic to avoid nested subs * [TLC-249] Lint * [TLC-249] Fix import typo (from merge conflict) * [TLC-249] Further test fixes * Retrieve the XSRF token first, and set it as both the XSRF header and cookie * Fix direct CSR By moving from environment.ts to config.yml we made it so the environment is _not_ up to date with the server configuration when main.js is first loaded. Because of this the app behaved as if CSR always happened _after_ SSR, effectively breaking direct CSR. Here the "criterion" for SSR/non-SSR HTML is changed from the related configuration property to the presence of Angular Universal transfer state. This means we can correctly determine when to bootstrap the app for direct CSR, and it's' now "safe" to just send index.html by itself. * Fix lint and test issues * Add "debug" config and "allowStale" configs * Add done() to async tests * 99053: Added test to check that the TYPE_REQUEST_FORGOT doesn't use the authentication-password.domain.valid * 97732 Remove unnecessary subscriptions * [CST-7757] subscriptions data service tests * Fixed text (without HTML tags) not being passed to child components * Fixed default @Input() values not working for themed components * [CST-7757] subscription modal tests * [CST-7757] modal fixes * [CST-7757] modal fixes * [CST-7217] Add margins to better align badge * [CST-7757] Hide delete info for new subscriptions and fix issue with unavailable items * Keep SSL sessions alive between xhr2 requests * [CST-7755] added cancel button to modal and updated message returned when a supervision order already exists * [CST-7755] lint fix * Fix bug where allowStale couldn't be disabled * 99053: Removed ngx-bootstrap dependency * 99053: Fixed encoded parameters being encoded twice in WorkflowItemActionPageComponent.previousPage() * 99053: Passed previousSearchQuery to AdvancedWorkflowActionSelectReviewerComponent * 99053: Passed previousSearchQuery to AdvancedWorkflowActionSelectReviewerComponent * 99053: Pass all queryParameters to advanced workflow pages by default * 99053: Save queryParams in init to prevent them being overwritten * Bump http-cache-semantics from 4.1.0 to 4.1.1 Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](https://github.com/kornelski/http-cache-semantics/compare/v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * [CST-7755] WIP refactoring * [CST-7757] Missing label * fixed issue in browser console * [CST-7755] WIP revert changes on list components * [CST-7757] Fix delete message * [CST-7755] Complete refactoring * Fix for "cannot read properties of undefined" error * [CST-8914] Add flag to show/hide csv export button * src/assets/i18n: Improve English strings for file upload Simple improvement to the wording in the file upload section of the item submission form. Also add a period at the end of the string. Fixes: #2096 * [CST-8935] Fix issue with missing matcher providers * translation fixes in security form * remove minimum passwort length value from translated messages * fixed missing comma * added comma to default translation * suggestionOption.name displayed * [CST-8952] Fix issue with admin reset password functionality * avoiding console.log errors * Fix param to send user the forgot password email * Update version tag for release * Fixed a lot of compilation errors, but there is a need to refactor services. * Added yarn.lock * Fixed some service updates * Fixed some service updates * Solved some errors, but it is still not working. * Something starting to work - the problem is in loading the modules * Updated database testing dump for integration tests * Fixed unit tests * Fixed admin menu * Fixed lint issues * Fixed handle page circular dependency * Fixed AuthorNameLink circular dependency * Fixed compilation errors * Fixed failing Unit tests * Integration tests should take image `migrate-to-7.5` * Integration tests should take image `migrate-to-7.5` * revert docker-compose-ci.yml changes * Updated BE envs * Changed localhost to 127.0.0.1 * Added DSPACE_UI_HOST and DSPACE_UI_PORT to 127.0.0.1:4000 * Changed logging in the IT * Fixed login * Maybe fixed integration tests * Copied a new code from the actual dtq-dev * Fixed discojuice login pop up * added S3 config to docker-compose-rest.yml * Fixed IT * Integration tests should not fail on console log error. * Removed failing test what is not needed. * SUbmitter user changed to admin * Commenteed failing tests. * added values for S3 to cli.yml * Added flags into discojuice * Added flags into discojuice * Added another icons into discojuice * discoPath is cleared in the discojuice.js * Create migrate-docker.yml to create docker image * create tag migrate-to-7.5 * Fixed some shibboleth problems * Fixed problem during downloading restricted bitstreams. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Kristof De Langhe <kristof.delanghe@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: Yura Bondarenko <yura.bondarenko@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Cristian Emanuelle Guzmán Suárez <cristian.guzman.contacto@gmail.com> Co-authored-by: Nathan Buckingham <nathan.buckingham@atmire.com> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Davide Negretti <davide.negretti@4science.it> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Art Lowel <art.lowel@gmail.com> Co-authored-by: Yury Bondarenko <ybnd@tuta.io> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Pascal-Nicolas Becker <pnbecker@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alan Orth <alan.orth@gmail.com> Co-authored-by: Sascha Szott <szott@gmx.de> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> * Fixed lint errors and updated server url * Created search instance in the services. * separate ports for multiple instance run (#230) * separate ports for multiple instance run * modified deploy * parametrized dspace project name in docker compose * fixed .env for deployment on dev-5 * fix forgotten -p parameter on deploy * fixed region * fixed bucket name * add DSPACE_VER variable to deploy * remove automatic deploy * unify erasing db * Autoregistration privacy policy redirect (#239) * Added missing searchData into metadataValueData service. * The user could be redirected into privacy policy page from the autoregistration welcome page. * Update erase_db.yml * Migrated 7.5/funding option wrong values (#241) * Fixed error when the part of the local sponsor value includes the SEPARATOR character. * The funds are properly loaded into complex input field. * revert replacing of the metadata value sequence, it will be fixed in the python * Revert "The funds are properly loaded into complex input field." This reverts commit 3f68b7955ccaf6eb722cd225c0bac02a678017af. * Added search button (#244) * Copied working code from the DSpace Vanilla 7.6 (#243) * add redeploy to dev-5 -> curl call to deploy action * format * remove forgotten action file (#252) * remove useless file * forgotten " * allow configuring host (#248) * migrated-7.5/look-and-feel-is-broken (#245) * Fixed item-view padding of the header * Fixed license label padding * Added margin right class into item view and if the item doesn't have the license it shows nothing in the license box in the item view. * Fixed loading of the license icons and padding. * Fixed padding of share buttons. * Fixed badges margin * Fixed item-box-view messaged, non-file message and padding. * Fixed files border. * Fixed clarin dropdown buttons because of Angular 13 and added padding into License table buttons * Added padding into handle table buttons. * Fixed ref box identifier url * Added missing method to the `clarin-search.component` (#247) * internal/shibboleth-missing-one-error-page * Update docker-compose-ci.yml Updated Integration Tests dump * Update build.yml Change DSPACE_CI_IMAGE to dtq-dev-7.5 * trigger docker images on correct branch * added password for dspace (#257) * added non-amazon-params (#260) * Update build.yml * Update build.yml * Internal/fix conflicts (#307) * trigger docker images on correct branch * fix updated postgres image on docker hub (#256) * internal-7.2/add-cz-language (#271) * Added a czech translation * Updated menu navbar and added translations. * disable deploy on dev-5 on version 7.2 * disabled deploy on dev-5 of dspace v7.2 --------- Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Nathan Buckingham <nathan.buckingham@atmire.com> Co-authored-by: Cristian Emanuelle Guzmán Suárez <cristian.guzman.contacto@gmail.com> Co-authored-by: Davide Negretti <davide.negretti@4science.it> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Art Lowel <art.lowel@gmail.com> Co-authored-by: Yury Bondarenko <ybnd@tuta.io> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: Pascal-Nicolas Becker <pnbecker@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alan Orth <alan.orth@gmail.com> Co-authored-by: Sascha Szott <szott@gmx.de> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: Kristof De Langhe <kristof.delanghe@atmire.com> Co-authored-by: Yura Bondarenko <yura.bondarenko@atmire.com> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * tul/merge-into-clarin-dspace (#316) (#317) * tul/merge-into-clarin-dspace (#316) * [CST-7757] Show object name * 98855: Remove temp themed ng-content container This is problematic when ng-content is provided but it's not used * [CST-7221] Opaque search bar * [CST-7757] Minor fixes * [CST-7757] Labels renamed * [CST-7755] updated PR to latest REST changes * 97298: Added form validator tests for restricted domains * 99053: Invalidate cache by default when performing the WorkflowItemActionPageComponent action * 99053: Added DeclinedTask search result banner * 99053: Fixed AdvancedWorkflowActionRatingComponent's rating from validation * 99053: Added missing documentation * [TLC-380] Support browse links and regex links in metadata display (resolved conflicts jan 2023) * [TLC-380] Lint fixes * [TLC-380] Lint fixes * [TLC-380] Unit test (provider injection) fixes (resolved conflict jan 16) * [TLC-380] lint fix * [TLC-380] further browse link unit test fixes (waitForAsync) * [TLC-380] Refactor browse links to use new /browses endpoint * [TLC-249] Fix circular dependency in browse services * [TLC-249] Larger refactor to field, item components for browse links * [TLC-249] Lint fixes * [TLC-249] Lint fixes * [TLC-380] Fix mock service to return proper payload * [TLC-380] Simplify / strip browse service from components * [TLC-380] Lint fixes for mock browse def service * [TLC-380] Template link, spec test, doc fixup as per review * [TLC-380] Refactor metadata rep list comp after rebase * [TLC-380] Lint fixes * [TLC-380] Template link fixes, spec test fixes Correct use of routerLink and queryParams Removed unused method from browse service, specs New spec tests for MetadataRepresentationListElementComponent * [TLC-380] Lint fixes on spec test * [TLC-380] Fix item page field test to supply router * [TLC-249] Show Identifier Step angular 7.x * [TLC-249] Remove CRIS7 visibility refs from component, i18n * [TLC-249] Lint fixes * [TLC-249] LGTM unused import fixes * [TLC-249] Register DOI operation and button in item status page * [TLC-249] Linting * [TLC-337] Unit tests for register DOI component * [TLC-249] Lint fixes * [TLC-249] Update data service usage since rebasing * [TLC-249] Update data service usage since rebasing * [TLC-249] Ensure identifier data model mapped to type * [TLC-249] Update spec test for new config form data service * [TLC-249] Addressing review feedback Adding comments and tidying some comments, imports Expect text for status not integer Send a 'type' parameter with a DOI registration Rename item-status.register to registerDOI As per todonohue's feedback on 2022-01-18 * [TLC-249] Addressing review feedback #2 Update WorkspaceitemSectionIdentifiersObject model to include a display types string array, so identifier types can be included or excluded from the step as needed. Update section template to work with the above new data As per todonohue's feedback on 2022-01-18 * [TLC-249] Lint fixes (imports, quotes) * [TLC-249] Improve model of identifier data in workspace section * [TLC-249] Update en.json5 with DOI status labels * [TLC-249] Identifier mock data updated in unit test * [TLC-249] Identifier mock data updated in unit test * [TLC-380] Renaming, changes as per review feedback * [TLC-380] WIP trying new routing / create flow * [TLC-380] Refactor to use new endpoints, better naming * [TLC-380] Refactor to use new endpoints, better naming * [TLC-249] Attempting art's sub fix (doesn't work) * [TLC-249] Update item status button logic to avoid nested subs * [TLC-249] Lint * [TLC-249] Fix import typo (from merge conflict) * [TLC-249] Further test fixes * Retrieve the XSRF token first, and set it as both the XSRF header and cookie * Fix direct CSR By moving from environment.ts to config.yml we made it so the environment is _not_ up to date with the server configuration when main.js is first loaded. Because of this the app behaved as if CSR always happened _after_ SSR, effectively breaking direct CSR. Here the "criterion" for SSR/non-SSR HTML is changed from the related configuration property to the presence of Angular Universal transfer state. This means we can correctly determine when to bootstrap the app for direct CSR, and it's' now "safe" to just send index.html by itself. * Fix lint and test issues * Add "debug" config and "allowStale" configs * Add done() to async tests * 99053: Added test to check that the TYPE_REQUEST_FORGOT doesn't use the authentication-password.domain.valid * 97732 Remove unnecessary subscriptions * [CST-7757] subscriptions data service tests * Fixed text (without HTML tags) not being passed to child components * Fixed default @Input() values not working for themed components * [CST-7757] subscription modal tests * [CST-7757] modal fixes * [CST-7757] modal fixes * [CST-7217] Add margins to better align badge * [CST-7757] Hide delete info for new subscriptions and fix issue with unavailable items * Keep SSL sessions alive between xhr2 requests * [CST-7755] added cancel button to modal and updated message returned when a supervision order already exists * [CST-7755] lint fix * Fix bug where allowStale couldn't be disabled * 99053: Removed ngx-bootstrap dependency * 99053: Fixed encoded parameters being encoded twice in WorkflowItemActionPageComponent.previousPage() * 99053: Passed previousSearchQuery to AdvancedWorkflowActionSelectReviewerComponent * 99053: Passed previousSearchQuery to AdvancedWorkflowActionSelectReviewerComponent * 99053: Pass all queryParameters to advanced workflow pages by default * 99053: Save queryParams in init to prevent them being overwritten * Bump http-cache-semantics from 4.1.0 to 4.1.1 Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](https://github.com/kornelski/http-cache-semantics/compare/v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * [CST-7755] WIP refactoring * [CST-7757] Missing label * fixed issue in browser console * [CST-7755] WIP revert changes on list components * [CST-7757] Fix delete message * [CST-7755] Complete refactoring * Fix for "cannot read properties of undefined" error * [CST-8914] Add flag to show/hide csv export button * src/assets/i18n: Improve English strings for file upload Simple improvement to the wording in the file upload section of the item submission form. Also add a period at the end of the string. Fixes: #2096 * [CST-8935] Fix issue with missing matcher providers * translation fixes in security form * remove minimum passwort length value from translated messages * fixed missing comma * added comma to default translation * suggestionOption.name displayed * [CST-8952] Fix issue with admin reset password functionality * avoiding console.log errors * Fix param to send user the forgot password email * Update version tag for release * Fixed a lot of compilation errors, but there is a need to refactor services. * Added yarn.lock * Fixed some service updates * Fixed some service updates * Solved some errors, but it is still not working. * Something starting to work - the problem is in loading the modules * Updated database testing dump for integration tests * Fixed unit tests * Fixed admin menu * Fixed lint issues * Fixed handle page circular dependency * Fixed AuthorNameLink circular dependency * Fixed compilation errors * Fixed failing Unit tests * Integration tests should take image `migrate-to-7.5` * Integration tests should take image `migrate-to-7.5` * revert docker-compose-ci.yml changes * Updated BE envs * Changed localhost to 127.0.0.1 * Added DSPACE_UI_HOST and DSPACE_UI_PORT to 127.0.0.1:4000 * Changed logging in the IT * Fixed login * Maybe fixed integration tests * Copied a new code from the actual dtq-dev * Fixed discojuice login pop up * added S3 config to docker-compose-rest.yml * Fixed IT * Integration tests should not fail on console log error. * Removed failing test what is not needed. * SUbmitter user changed to admin * Commenteed failing tests. * added values for S3 to cli.yml * Added flags into discojuice * Added flags into discojuice * Added another icons into discojuice * discoPath is cleared in the discojuice.js * Create migrate-docker.yml to create docker image * create tag migrate-to-7.5 * Fixed some shibboleth problems * Fixed problem during downloading restricted bitstreams. * Disabled end user agreement page with footer options (#220) * Full customization for TUL (#217) * customize header, footer and homepage * add hover on button and contact us in the footer * add hover for logo and fix UI * transform into valina page and apply the hover style for the link * change search page into Vanila space default * fix exapandable navbar item behaviour * change the background of side admin bar and hide some options of it * replace dspace logo with tul logo * fix gray border of button * add new component for CitacePRO and handle with dynamic data from item object * fix merged issues * make the url as the constant value * hide the clarin license * add description into en.json5 * change the position of the citation and edit test * retrieve the constants from the BE * change the fixed value * calling new API from BE * remove privacy policy in the footer * add new page without content * create content for the contact page and add text in i18n for translation * receive email property from BE and add,fix unit tests * edit the href for contact page * change the fetch address --------- Co-authored-by: HieuHorizonsfl <huynhnhatkhoa21@gmail.com> Co-authored-by: HieuHorizonsfl <105620951+HieuHorizonsfl@users.noreply.github.com> Co-authored-by: HuynhKhoa1601 <89246737+HuynhKhoa1601@users.noreply.github.com> * Tul/fixing (#225) * customize header, footer and homepage * add hover on button and contact us in the footer * add hover for logo and fix UI * transform into valina page and apply the hover style for the link * change search page into Vanila space default * fix exapandable navbar item behaviour * change the background of side admin bar and hide some options of it * replace dspace logo with tul logo * fix gray border of button * add new component for CitacePRO and handle with dynamic data from item object * fix merged issues * make the url as the constant value * hide the clarin license * add description into en.json5 * change the position of the citation and edit test * retrieve the constants from the BE * change the fixed value * calling new API from BE * remove privacy policy in the footer * add new page without content * create content for the contact page and add text in i18n for translation * receive email property from BE and add,fix unit tests * edit the href for contact page * change the fetch address --------- Co-authored-by: HieuHorizonsfl <huynhnhatkhoa21@gmail.com> Co-authored-by: HieuHorizonsfl <105620951+HieuHorizonsfl@users.noreply.github.com> Co-authored-by: HuynhKhoa1601 <89246737+HuynhKhoa1601@users.noreply.github.com> * Internal/multideploy support 2 (#240) * fixed deployment values for TUL customer * added DSPACE_VER * actually append to the .env file * remove automatic deploy * unify erasing db * fix correct branch in call after erase_db * add redeploy to dev-5 -> curl call to deploy action * forgotten " in github action * correct redeploy branch in github action * trigger docker images on correct branch * added password env var (#258) * added non-amazon params (#261) * Tul/customize fe (#254) * Disabled end user agreement page with footer options * Added padding to icon * If the citacePro properties is not defined in the BE, do not throw the errors * Added dtq sign into footer * Dataquest URL is loaded from the cfg * Load the company name which has customized this DSpace from the cfg * Updated Home News page header * Prettify the code * Update deploy.yml * Update build.yml * Update build.yml * Update docker-compose-ci.yml Updated dump for the integration tests * Added purple into .btn-dark class (#263) * Internal/update and secure docker compose (#269) * added timezone * added IP spec to all open ports on prod docker-composes * removed now-false disclaimer about similarity to backend docker composes * removed redundant host parameter in Dockerfile * changed port on which to expect REST * make envinronment production * revert to serve for now * revert to serve for now * typo * revert run command in dockerfile * no need to run on host 0.0.0.0 * needed due to upgrade to docker compose v2 * tul/login-case-sensitive * port change (so as not to expose 8086) * tul/turn-off-language-translations * Show error message from the error response (#275) * Tul/fix integration tests (#276) * Fixed admin spec IT - TUL doesn't have supported /licenses and /handle * Commented out test class `submission-ui` because it is suitable only for the CLARIN-DSpace * Commented out CLARIN license step for the submission IT * Changed klaro cookies modal styles according to TUL requirements. (#288) * tul/after_test-3-badge-color (#289) * Updated badge color * badge style rule moved for the _clarin-styles.scss * Fixed conflicts * Removed thumbnail message (#290) * tul/after_test-6-underlined-links (#291) * All links are underlined except buttons, facet filters and nav links. * Fixed ugly coflicts * tul/after_test-8-navbar-gasps * Updated topLevelCommunityList pagination (#293) * tul/13-add-czech-language (#272) * Added CLARIN-DSpace-7.2. czech language * Added script to find out which messages must be translated. * Updated czech login message because text was too big * Keep allowed only EN and CZ language * Updated new czech translations * Updated new czech translations * "Sbírka" translated to "Kolekce" * Updated final version of czech translation * Revert "Updated final version of czech translation" This reverts commit 0261c85909c1fa83a9d3faa54f26e64a53232cbb. * Revert "Revert "Updated final version of czech translation"" This reverts commit 644cfaa5fd7e0fde526141ac1827af7f99a80e3b. * Merged customer/TUL files * pretyfied python script file * Tul/13 add czech language (#297) * Added CLARIN-DSpace-7.2. czech language * Added script to find out which messages must be translated. * Updated czech login message because text was too big * Keep allowed only EN and CZ language * Updated new czech translations * Updated new czech translations * "Sbírka" translated to "Kolekce" * Updated final version of czech translation * Revert "Updated final version of czech translation" This reverts commit 0261c85909c1fa83a9d3faa54f26e64a53232cbb. * Revert "Revert "Updated final version of czech translation"" This reverts commit 644cfaa5fd7e0fde526141ac1827af7f99a80e3b. * Merged customer/TUL files * pretyfied python script file * Updated some messages * modified to production config (#296) * added dummy local.cfg and set up docker-compose (#278) * tul/after_test-9-set-up-banner (#294) * Updated topLevelCommunityList pagination * Prepared home-page for a banner * Banner in the top * Refactoring * Updated TUL favicon (#300) * tul/fix-wrong-favicon (#302) * Updated message and favicon icon * trying to fix ssr github action error * Added deleted favicon.ico * revert language changes * revert language changes * revert language changes * Changed Domov message * Removed DSpace Angular :: message * Removed DSpace Angular :: message * Updated prefix DSpace * Customer/tul wrong dockerfile missing pm2 (#304) * added pm2 * forgot pm2, of course * customer/TUL-mount-prod-cfg-2 * 7 pm2 nodes (#313) * 7 pm2 nodes * mistake fix * tul/show-doi (#315) * Show DOI full link in the identifier field in the item view. * Just prettify * Fixed failing test * Just prettify --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Davide Negretti <davide.negretti@4science.it> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Art Lowel <art.lowel@gmail.com> Co-authored-by: Yury Bondarenko <ybnd@tuta.io> Co-authored-by: Nathan Buckingham <nathan.buckingham@atmire.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Pascal-Nicolas Becker <pnbecker@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cris <cristian.guzman.contacto@gmail.com> Co-authored-by: Alan Orth <alan.orth@gmail.com> Co-authored-by: Sascha Szott <szott@gmx.de> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: HieuHorizonsfl <huynhnhatkhoa21@gmail.com> Co-authored-by: HieuHorizonsfl <105620951+HieuHorizonsfl@users.noreply.github.com> Co-authored-by: HuynhKhoa1601 <89246737+HuynhKhoa1601@users.noreply.github.com> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * pretiffy commit * Git revert unwanted changes * temp commit * Updated dtq-dev * Fixed removing of empty row * Added forgotten functionalities into clarin merge * Fixed review requirements * removed unwanted tests * Updated help script comment * Updated test image for FE integration tests --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Davide Negretti <davide.negretti@4science.it> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: corrado lombardi <corrado.lombardi@4science.com> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Kim Shepherd <kim@shepherd.nz> Co-authored-by: Art Lowel <art.lowel@gmail.com> Co-authored-by: Yury Bondarenko <ybnd@tuta.io> Co-authored-by: Nathan Buckingham <nathan.buckingham@atmire.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.it> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Pascal-Nicolas Becker <pnbecker@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cris <cristian.guzman.contacto@gmail.com> Co-authored-by: Alan Orth <alan.orth@gmail.com> Co-authored-by: Sascha Szott <szott@gmx.de> Co-authored-by: MajoBerger <marian.berger@dataquest.sk> Co-authored-by: HieuHorizonsfl <huynhnhatkhoa21@gmail.com> Co-authored-by: HieuHorizonsfl <105620951+HieuHorizonsfl@users.noreply.github.com> Co-authored-by: HuynhKhoa1601 <89246737+HuynhKhoa1601@users.noreply.github.com> Co-authored-by: MajoBerger <88670521+MajoBerger@users.noreply.github.com> * ufal/some-messages-are-missing (#328) * Added missing item-view-box messages. * Added commented english messages. * new project issue assign * After click on Item link you won't be redirected to handle url. (#331) * ufal/fe-date-is-not-showed-in-the-item-view * ufal/update-index-for-language (#340) * Updated language in the item view * Fixed language facet in the search * changed entrypoint for dspace angular container (#343) * store logs in volume (#336) * enable deployment of clarin * internal/fe-redirect-user-after-local-login (#341) * The redirectUrl is passed from the discojuice login into state.redirectUrl * Prettifying the code * fix deployment (#346) * correct tag (#347) * correct BE port * correct REST port for deployment * ufal/fe-show-login-modal-no-redirect (#344) * The redirectUrl is passed from the discojuice login into state.redirectUrl * Prettifying the code * Show discojuice on login page * Refactoring * Discojuice after click on close the use won't be redirected to the home page. * Fixed failing tests * Added accidentally removed timeout. * Fixed merge conflict * Fixed lint error * modify expected .env and docker composes (#349) * Update docker.yml * Update deploy.yml * ufal/fe-license-has-only-one-type * The Item type is fetched from the `metashare.ResourceInfo#ContentInfo.mediaType` metadata * Removed unwanted change * fix escaped variables in deploy * correct version of images * correct deploy port for FE * added anonymous caching for frontend (#364) * added anonymous caching for frontend * newlineeee * srsly * ufal/fe-22-54-download-preview-item (#362) * create new component and add model file and service file * build the user interface and calling the api from backend * add logic for handling data from BE and refactor the UI * fix the lint error and fix the collapse/hide behaviour * add UI for download buttons and fix UI for the ZIP Preview * getting data from backend and make the download feature * handle with the dynamic input * fix the collapese/hide behaviour and handle more cases * add more conditions for checking permission to preview and download files * fix lint error * fix failed test * Lock/download preview (#311) * create new component and add model file and service file * build the user interface and calling the api from backend * add logic for handling data from BE and refactor the UI * fix the lint error and fix the collapse/hide behaviour --------- Co-authored-by: HuynhKhoa1601 <huynhnhatkhoa21@gmail.com> * Resolved conflicts * Revert unnecessary changes * Refactoring and removed font awesome loading from node modules * Updated preview file box look and feel * Fixed file preview icons * Fixed html preview scrolling * Show scrollbar in txt preview * Some refactoring * Refactoring and the dspace BE is loaded from configuration property. * Added messages * Fixed tests * Added download buttons and fixed downloading * Added messages * Added image to the assetstore instead of url from lindat --------- Co-authored-by: HuynhKhoa1601 <huynhnhatkhoa21@gmail.com> * ufal/fe-assetstore-files-are-not-loaded (#371) * Redirection was broken after updating the namespace. The redirection links was changed from `href` to `routerLink` * Fixed test * Fixed test * namespace could be empty * ufal/fe-cannot-load-license-images-on-the-first-load (#373) * The license labels are loaded in the same way than in the clarin item view box. * Fixed failing unit test * Update Dockerfile Increase network timeout * docker/build-push-action@v3 to v4 * Update Dockerfile * updated node to version 18:18 and generated a new yarn.lock file * build images on dev-5 * internal/ngx-mask-update-fix (#375) * ngx-mask library made an update and it destroyed project build * Downgraded @yarnpkg/parsers to version 3.0.0-rc.32 because node v16 cannot run * Update docker.yml * Update erase_db.yml Enabled redeploy * internal/fe-redirection-from-where-login-was-initiated-still-not-working-properly * ufal/fe-license-static-pages-are-missing (#380) * Added static files and redirection * Html content is loaded from the static file and rendered in the component. * The html file content is showed in the `static/` route with the error page. The translation works. * Created routing for the `licenses` page and changed administrator license table to `licenses/manage-table` path * Show all licenses data. * All licenses are filtered by license label - PUB, ACA, RES * Added loading bar * Added redirect from license selector * Fixed tests. * Refactoring * Fixed lint error - unused import * Added docs and translations. * Removed accidentally added semicolon. * Added simple test if the html file content will be loaded. * ufal/ref-box-content-is-not-immediately-copied * ufal/fe-bottom-menu-during-submission-creation-must-be-fixed * ufal/fe-remove-grid-option-in-the-search-page (#386) * Removed Grid view from the initial viewModeList * Fixed failing test on clarin all licenses page. * add sample file to assetstore on every deploy * ufal/fe-update-vanilla-table-item-versions * Updated item versions table and defined translations. * Removed test of removed columns * Versions temp commit * All versions are shown * Show all versions from metadata * Added docs and comments. * The user is redirected to the right download page after clicking on `Download file` button. * ufal/there-is-static-source-in-html-preview * turn off S3 * [devOps] create new dspace instance with imported data * ufal/fe-history-table-is-still-seen (#392) * The version table is hidden if the item doesn't have any versions and the name is of the version is properly loaded. * Undo unwanted changes. * [devOps] enable reusing, multiple instances * debug and fix deploy and import * linux, not windows * [devOps] import/erase/deploy workflows refactored * [devOps] import/erase workflows * [devOps] import/erase workflows * [devOps] import/erase workflows * [devOps] import/erase workflows * use composite actions instead of reusable workflows * [devOps] using composite * [devOps] using composite * [devOps] using composite * [devOps] using composite * Update deploy.yml, increase timeout * Update deploy.yml * fix deploy to respect "import" switch * ufal/downloading-restricted-bitstreams-not-working-properly (#393) * Get redirect from previous page. * The user is redirected to the downloading of the bitstream after login. * Show right breadcrumbs during downloading the bitstream * The user is redirected to the zip download page. * The auth token is send in the file download link. * Added default tests * Fixed typo and checked that url won't be broken in two places. * by default only deploy to INSTANCE=5 * give more time for postgres init * add even more time * Update action.yml (#405) Run import from main branch * ufal/fe-update-json-messages Added missing tranlates and updated messages after running the script * ufal/fe-initiated-login-not-redirecting-from-collection Redirect to login with `redirectUrl` param because it is lost after click on `local` login button. (#404) * [devOps] add dspace commands after import * ufal/fe-add-default-static-pages (#406) * Added static pages from the lindat git * Fixed redirection and created safeHtml pipe. * Could redirect out of namespace url, small refactoring. * Updated tests. * Added images into the static pages. * ufal/fe-shibboleth-validate-emails * Encoded query params (#407) * placeholder configs to be mounted into docker * change entrypoint so that containers has less logs and restarts (#412) * ufal/fe-get-user-ip-address (#420) * The clients IP address is fetched from the BE API. * Replace LegacyBitstreamUrlResolver by BitstreamBreadcrumbResolver because the first one throws errors to the console. * ufal/fe-fix-static-page-redirect (#421) * Fixed static page redirects. * Refactored processing links. * ufal/fe-download-bitstream-back-to-item (#423) * Separated toggling of DiscoJuice popup from the workign with redirect URL * The downloading page is loaded before downloading. * Login redirect works. * Removed storing cookies in the aai.js * ufal/fe-oversized-file-upload-message (#424) * If the file exceeds the upload max file size the uploading will be stopped before starting and the user will see proper error message. * Fixed unit tests - added configurationDataService * ufal/fe-item-view-license-box (#427) * Do not show licenses if the Item doesn't have any file. * ufal/fe-email-restricted-download (#430) * ClarinAuthorization passed, but vanilla not because of vanilla check - I added dtoken into vanilla authorization url and because of that the vanilla authorization will be passed. * Added message for the expiration token message - it was hardcoded. * ufal/fe-not-show-shib-welcome-page * Loaded property from the cfg and check if the page with idp attributes could be showed up. If not redirect the user to the home page. (#431) * ufal/fe-s3-customization (#428) * The admin could see in the bitstream admin UI if the bitstream is stored in both storages (S3, local). * Fixed failing unit test - updated columnSizes object * ufal/curate-translation-missing Added curate collection edit translation and curation task name. (#434) * ufal/upload-on-first-attempt-fix (#435) * Moved file size limit into FileUploader options and handled Upload cancelation. * Check that uploading is successful * ufal/fe-show-checksum-result (#432) * BitstreamChecksum values are fetched and parsed from the BE * Checksum info is showed up. * Added messages and translations. * Added docs and refactored code * Fixed failing tests * Fixed wrong czech translations. * ufal/shibboleth-redirect-from-login (#433) * Send redirectUrl param to the IdP in the target url * The code is updated to be more readable. * internal/increase-server-memory-limit (#411) * Update docker-compose-rest.yml Increase memory limit to 4GB * Load JAVA_OPTS from the .env file. * ufal/shibboleth-encode-redirecturl (#438) * Compose redirectURL if the redirection is initiated from the login page and encode that URL because server cannot process decoded URL. * Removed unused getCookie method. * Updated if condition - it was made more readable * Avoid accessing an out-of-bounds index in the split question marks array. * internal/docker-remove-orphans (#439) * Removed --remove-orphans flag because it doesn't have any effect. * internal/update-config * Copied missing parts from TUL:config/config.yml (#441) * internal/fe-upgrade-clarin-dspace-7.6 (#450) * Fix accessibility of date sliders by adding aria-labels (cherry picked from commit 2a881791ba76091d2f85d0b068f926043ef33bc9) * Minor fixes to cypress tests (cherry picked from commit 70a7bbe3cbdd24abaf7f6f791ef60e88a3ae8922) * Fix heading order accessibility issue in search filters/facets (cherry picked from commit 276d80895e38225fcbde38cab01d79cd31a34e9b) * Spanish translation updated to 7.6 (cherry picked from commit 4cc4192e93aea3eb7dddc8486fe1fad35b6103bc) * Some lint errors fixed (cherry picked from commit 1885638ba6fadca4c99043db4ce52646bce435a3) * 🐛 fix when navbar expands on firefox (cherry picked from commit 60706720e4…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some tests and TypeDoc to the existing code base.
Change list
Wrote tests for:
Added/Updated TypeDoc for:
Cleaned up: