Collection dropdown on MyDSpace & support enable/disable in Submission UI

[ddinuzzo]

References

Fixes #671
Fixes #673

Description

In this PR has been added:

• a new shared component used to display list of collections. This component is used as the collection dropdown in the Submission UI, as the collection selector in the Admin Sidebar menu and to start a new submission from the MyDSpace page
• support to enable/disable the collection dropdown in the Submission UI

Instructions for Reviewers

• This PR must have to testing with REST API presents in another PR (DS-4504 Performance issues with finding Collections a user can submit to DSpace#2771)
• to test the status (enabled/disabled) of the collection dropdown in the Submission UI comment/uncomment the collection step in the submission configuration.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
• My PR passes Checkstyle validation based on the Code Style Guide
• My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
• My PR passes all tests and includes new/updated Unit or Integration Tests for any bug fixes, improvements or new features. A few reminders about what constitutes good tests:
  • Include tests for different user types, including: (1) Anonymous user, (2) Logged in user (non-admin), and (3) Administrator.
  • Include tests for known error scenarios and error codes (e.g. 400 Bad Request, 401 Unauthorized, 403 Forbidden, 404 Not Found, etc)
  • For bug fixes, include a test that reproduces the bug and proves it is fixed. For clarity, it may be useful to provide the test in a separate commit from the bug fix.
• N/A If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• N/A If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

[tdonohue]

Just wanted to add a quick note here to say that I've reviewed the code and it all looks good/reasonable. I haven't had a chance to test this yet though, but will do so tomorrow.

[artlowel]

Thanks @ddinuzzo !

The performance of the collection select is much improved!

• On mydspace, when I click the new submission button, I get the collection select, as was discussed. However if you drop a file on the dropzone, I get a notification that the workspace item was created: click HERE to edit it. If I click HERE I go straight to the submission. I would expect to also get the collection select first in this case.
• Not new in this PR, but the word HERE in that notification is positioned strangely, it is lower than the rest of the text. There's also no need to put in in all caps.

[atarix83]

thanks @artlowel for review

On mydspace, when I click the new submission button, I get the collection select, as was discussed. However if you drop a file on the dropzone, I get a notification that the workspace item was created: click HERE to edit it. If I click HERE I go straight to the submission. I would expect to also get the collection select first in this case.

This will be fixed in a follow-up PR regarding this issue

Not new in this PR, but the word HERE in that notification is positioned strangely, it is lower than the rest of the text. There's also no need to put in in all caps.

we will fix it

[ddinuzzo]

Hi @artlowel !
I have fixed the position of the word "here" in the notification

[lgtm-com]

This pull request introduces 3 alerts when merging f37de54 into bb70591 - view on LGTM.com

new alerts:

• 3 for Unused variable, import, function or class

[artlowel]

Thanks

[atarix83]

@tdonohue since the related REST PR was merged I realized is urgent to merge this PR in the master, otherwise Angular app doesn't work properly
could you give a test as soon as you can? thanks

[tdonohue]

👍 Looks good to me. Thanks for the friendly reminder @atarix83 on getting this reviewed & merged.