New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit collection item template #749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-item-template
…tion-item-template
Conflicts: resources/i18n/en.json5 src/app/+collection-page/collection-page-routing.module.ts src/app/+collection-page/collection-page.module.ts src/app/core/core.module.ts src/app/core/data/data.service.ts src/app/shared/shared.module.ts
Conflicts: resources/i18n/en.json5 src/app/+collection-page/collection-page.module.ts src/app/+collection-page/edit-collection-page/collection-metadata/collection-metadata.component.html src/app/+collection-page/edit-collection-page/collection-metadata/collection-metadata.component.spec.ts src/app/+collection-page/edit-collection-page/collection-metadata/collection-metadata.component.ts src/app/core/core.module.ts src/app/core/data/data.service.ts src/app/shared/shared.module.ts
…tadata fields to update
… keep them stored in the object-updates store
Conflicts: src/app/+collection-page/collection-page-routing.module.ts src/app/+item-page/edit-item-page/abstract-item-update/abstract-item-update.component.ts src/app/+item-page/edit-item-page/edit-item-page.module.ts src/app/+item-page/edit-item-page/item-metadata/item-metadata.component.ts src/app/core/cache/server-sync-buffer.effects.ts src/app/core/core.module.ts src/app/core/data/data.service.ts src/app/core/data/dso-change-analyzer.service.ts src/app/core/data/object-updates/object-updates.service.ts
Conflicts: src/app/+collection-page/edit-collection-page/collection-metadata/collection-metadata.component.spec.ts src/app/+item-page/edit-item-page/abstract-item-update/abstract-item-update.component.ts src/app/+item-page/edit-item-page/edit-item-page.module.ts src/app/+item-page/edit-item-page/item-metadata/item-metadata.component.ts src/app/core/core.module.ts src/app/core/data/data.service.ts
Conflicts: src/app/core/auth/auth-request.service.ts src/app/core/core.module.ts
This pull request introduces 3 alerts and fixes 7 when merging b77fd69 into 2fe9965 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request fixes 10 alerts when merging 92e47de into 2fe9965 - view on LGTM.com fixed alerts:
|
tdonohue
added
the
1 APPROVAL
pull request only requires a single approval to merge
label
Jul 2, 2020
tdonohue
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This PR closes #662
Description
This PR adds the ability to edit the template item of collections.
This PR is something we created a while back, but was never completely finished due to the reduced priority of the item template feature. However, this PR fixes issue #662, so we'd like to contribute this now.
Instructions for Reviewers
Changes made:
ItemTemplateDataService
EditItemTemplatePageComponent
at route/collection/${collection-uuid}/itemtemplate
. This page displays the metadata of the collection's template item and the ability to edit them (similar to edit metadata of a regular item, it uses the same child component)How to test:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lint
package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.