Support for process output on detail page

[MarieVerdonck]

References

• Depends on: Scripts and processes - Script output DSpace#2934

Description

This PR shows the output of a Process on the process' detail page at {dspaceUI}/processes/

Instructions for Reviewers

The logs of the process are are a list of strings, shown underneath each other is a < pre > section.
If the process has no ProcessOutput or the logs in the ProcessOutput is just an empty array, then a message is shown.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes TSLint validation using yarn run lint
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs for any bug fixes, improvements or new features. A few reminders about what constitutes good tests:
  • Include tests for different user types (if behavior differs), including: (1) Anonymous user, (2) Logged in user (non-admin), and (3) Administrator.
  • Include tests for error scenarios, e.g. when errors/warnings should appear (or buttons should be disabled).
  • For bug fixes, include a test that reproduces the bug and proves it is fixed. For clarity, it may be useful to provide the test in a separate commit from the bug fix.
• If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[lgtm-com]

This pull request introduces 1 alert when merging 8325a34 into eb98098 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[tdonohue]

@MarieVerdonck : Thanks for this PR! I gave this a code review today, and the code looks good (just one minor inline comment below).

Overall, it looks like it should work, however I was unable to test it as the backend PR (DSpace/DSpace#2905) is not working to build/install today (it throws errors when I try to run it). So, without a backend to test against, I was only able to do a code review.

As I'm about to leave on holiday for a week, I'll note that I'm +1 for this PR as-is provided that someone else can test it & verify it works against the backend once that backend PR is fixed/updated (as noted in this comment, that PR is planned to be refactored anyhow to change the implementation).

[tdonohue]

@MarieVerdonck : Code here looks good overall. But, when I test it alongside the REST PR (DSpace/DSpace#2934), every request for a single Process (UI Path: /processes/[id])results in a "404 OK" error from the backend.

It looks to me like the request being sent from the UI might be invalid, as the embed=output param doesn't seem to work from the REST API either. So, here's what the request looks like that results in a 404: http://localhost:8080/server/api/system/processes/4?embed=script&embed=output

I'm also not sure whether we should always embed the entire output...as some of the output might be large in size. So, it seems like we should have a way to view the simple information about the process prior to opening the output. But, maybe I'm misunderstanding the purpose of that command.

[tdonohue]

@MarieVerdonck : I re-tested this with the backend PR (DSpace/DSpace#2934). It's not quite working as expected, though it's no longer throwing obvious errors.

Here's the behavior I see:

• First, I kick off a new process from http://localhost:4000/processes/
• I immediately click on the new process while the process is in the "Running" status.
  • Bug: While the process is "running", I see the Process Output section & "Retrieve process output" button...even though no output is yet available.
• Bug: Once the process is "Completed", I click on the "Retrieve process output" and get a response that "no process output is available". But, if I look at the Chrome DevTools, I see that the 200 response included a "content" link which allows me to download the content directly from the REST API. So, it looks like the UI is not finding that "content" link.
• Bug: If I go to an old process (one with no output), and click on "Retrieve process output", I just see the "Retrieving..." message forever. If I look at Chrome DevTools, I see it responded with a 204 No Content response, but it looks like the UI didn't handle that response.

[tdonohue]

@MarieVerdonck : Could you rebase this PR on the latest code? It looks like there's a small merge conflict here now & I'd like to be able to re-test this PR with the new backend PR (DSpace/DSpace#3009)

[tdonohue]

👍 @MarieVerdonck : I've re-reviewed & retested this today with the new backend PR (DSpace/DSpace#3009) and it works exactly as described (all my previously reported issues are gone as well). The code looks good too. Thanks!