-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
remove it, we can get rid of the Commons Logging dependency. Also add some direct dependencies drawn in by our modified FacetComponent.
@@ -20,7 +20,7 @@ | |||
<parent> | |||
<groupId>org.dspace</groupId> | |||
<artifactId>dspace-pom</artifactId> | |||
<version>10</version> | |||
<version>12</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment: We should eventually clean up this reference to "dspace-pom". This old "dspace-pom" concept is no longer maintained or used. We should work to remove it and instead have the main 'dspace-solr" pom.xml setup similar to the root pom.xml in the main DSpace source.
That work doesn't have to happen in this pull request. But, we should do it preferably before 4.0, to avoid referencing this now outdated 'dspace-pom'. I'd be willing to help with it as needed.
I had to adjust the POMs already, so why not go ahead and fix them properly? This was a little tricky, since the top POM describes our tweaks to an Apache project. I think I got the licensing, attributions, etc. right but please check. The mailing lists and the like, I feel, should point to DSpace. |
Perhaps we should discuss what out-of-the-box logging configuration we will provide for Solr for DSpace. Solr is quite chatty. I suggest adding a new appender to divert this stuff to another file, and perhaps reducing the log level as Hilton suggests in the ticket. |
[DS-1460] Add SOLR logging config file
Move from java.util.logging to log4j. Modern Solr releases use slf4j and add adapters to emulate other frameworks. Set a context parameter "log4j.configuration" to a URL that points to a log4j configuration (for example, to [DSpace]/config/log4j.properties).