Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor errorBoundary #308

Merged
merged 2 commits into from
Apr 20, 2023
Merged

feat: refactor errorBoundary #308

merged 2 commits into from
Apr 20, 2023

Conversation

JackWang032
Copy link
Collaborator

ErrorBoundary

  • 移动LoadError组件至ErrorBoundary内
  • 新增onError属性
  • 新增errorPage属性用于自定义错误捕获页面

预览地址 https://jackwang032.github.io/dt-react-component/components/errorboundary

@JackWang032 JackWang032 added the refactor This will improved code readability and reduced complexity label Apr 17, 2023
@JackWang032 JackWang032 requested a review from mumiao April 17, 2023 09:30
@JackWang032 JackWang032 self-assigned this Apr 17, 2023
@mumiao mumiao requested a review from mortalYoung April 18, 2023 02:09
@mumiao mumiao added this to the Next Version(4.0.0） milestone Apr 18, 2023
@mumiao
Copy link
Collaborator

mumiao commented Apr 19, 2023

我这边问题不大，这个 @mortalYoung 再最后Check一下，changelog更新部分记得体现loadError组件deprecated了，迁移到ErrorBoundary @JackWang032

mortalYoung
mortalYoung approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

mumiao
mumiao reviewed Apr 20, 2023
View reviewed changes
src/errorBoundary/index.tsx Outdated Show resolved Hide resolved
src/errorBoundary/index.tsx Outdated Show resolved Hide resolved
@mumiao mumiao merged commit 4bf39ea into DTStack:feat_v4 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumiao mumiao mumiao approved these changes

@mortalYoung mortalYoung mortalYoung approved these changes

Assignees

@JackWang032 JackWang032

Labels
refactor This will improved code readability and reduced complexity
Projects
None yet
Milestone
Next Version(4.0.0）
Development

Successfully merging this pull request may close these issues.
3 participants
@JackWang032 @mumiao @mortalYoung