Couple of bug fixes and minor improvements #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @arni-magnusson, really appreciate all these bug fixes and improvements. We have been working on the |
alko989
added a commit
that referenced
this pull request
Dec 8, 2023
--------- Co-authored-by: Tobias Mildenberger <t.k.mildenberger@gmail.com> Co-authored-by: Alexandros Kokkalis <alko@aqua.dtu.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've been using SPiCT for the last couple of days and made a few small changes to it along the way. In chronological order:
96b589b - Reading the
get.parhelp page, I noticed the 'Value' section looked like it was missing columns 2), 3), and 4). It turned out to be percent signs that needed to be escaped. Fixed the same in a few other help pages.1de4e59 - Then I started reading the vignettes and found that the spict_handbook.Rmd wouldn't compile. This also prevented a plain 'R CMD check' to complete. The error was related to a bug in
make.man.inpthat is now fixed.ccfca90 - While waiting for 'R CMD check' to finish, I made a small improvement in the
fit.spicthelp page, using \enumerate to format the numbered list. Likewise, one could use \describe instead of \itemize for the description lists, but that's a layout decision that I wasn't ready to make :)d089780 - The next error in the spict_handbook.Rmd was related to a bug in
add.manlinesthat is now fixed. R 4.2 introduced a strict rule that if-conditions must be of length one. The vignette errors were affecting all user analyses that resemble those in the vignette, so I've documented the fixes in the NEWS file.a9e8560 - Now that 'R CMD check' was working, I resolved a low-hanging warning about an unused require(pscl) call inside
plot.priors.626058a - An error when running the package examples was related to
man.selectwhich is now fixed.7e136fb - Resolved a warning about a missing \description field in the package help page.
058f130 - Fixed a warning about undocumented function arguments.
9341eff - Finally, fixed a few minor typos.
This pull request brings 'R CMD check' from 3 errors + 6 warnings down to 0 errors + 3 warnings. The remaining ones do not seem very important.