Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VK_BASALT_EXPORT #208

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Add VK_BASALT_EXPORT #208

merged 2 commits into from
Mar 2, 2023

Conversation

juan-lunarg
Copy link
Contributor

closes #207

juan-lunarg
juan-lunarg commented Feb 27, 2023
View reviewed changes
src/meson.build Outdated Show resolved Hide resolved
@juan-lunarg
gnu_symbol_visibility should be hidden by default
917beb6 
Avoids exporting unintended symbols
@juan-lunarg
Copy link
Contributor Author

@DadSchoorse does the PR look good to you?

@DadSchoorse DadSchoorse merged commit 868498a into DadSchoorse:master Mar 2, 2023
@DadSchoorse
Copy link
Owner

Thanks for the fix!

@juan-lunarg juan-lunarg deleted the juaramos/VK_BASALT_EXPORT branch March 2, 2023 19:10
@FireBurn FireBurn mentioned this pull request Apr 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgurr tgurr tgurr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.3.2.8: fails to build with error: 'VK_LAYER_EXPORT' does not name a type
3 participants
@juan-lunarg @DadSchoorse @tgurr