use explicit wording for reading cvar value

[illwieckz]

hOw DiD wE mIsSeD tHaT fOr So lOnG? 🤔️

[DolceTriade]

I think this code works fine...

Daemon/src/common/Cvar.h

Line 123 in 895cb2c

T operator*() const;

Means that * is overloaded to call Get()

[illwieckz]

I think this code works fine...

Daemon/src/common/Cvar.h

Line 123 in 895cb2c

T operator*() const;

Means that * is overloaded to call Get()

Ah… Well, I prefer explicit code. 🤷‍♀️️

[illwieckz]

I renamed the commit renderer: use explicit wording for reading cvar value.

[slipher]

Should we nuke operator*?

[illwieckz]

Should we nuke operator*?

I was going to ask the same. I don't want to have to guess the behavior of *ptr knowing it may differ according to the object type. It seems to just add extra mental load only to save on characters and allowing some kind of obfsucated code golf…

So if someone nukes it, I will approve…

[illwieckz]

I added a commit to NUKE the confusing *cvar syntax, it was used nowhere else.

[slipher]

LGTM