Make the legacy dynamic light renderer work again #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GL_BindToTMU calls GL_Bind that prints a warning on such situation but GLBindToTMU attempts to reade members before calling GL_Bind and then crash.
…ng* like Render_lightMapping
illwieckz
force-pushed
the
illwieckz/legacy-dynamic-lighting
branch
from
e5d6d3c
to
76bf4f8
Compare
DolceTriade
reviewed
Apr 22, 2024
illwieckz
force-pushed
the
illwieckz/legacy-dynamic-lighting
branch
from
949ddcc
to
107ae30
Compare
illwieckz
force-pushed
the
illwieckz/legacy-dynamic-lighting
branch
from
107ae30
to
60a3606
Compare
DolceTriade
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something is wrong as the light is too dim, but it works.
About the wrongness, here with both map dynamic light, and weapon projectile dynamic light:
It should look like this: