New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add list used files command #160
base: master
Are you sure you want to change the base?
Conversation
I feel like some combination of "which" and autocomplete somehow already does this. |
This is not the only interface for opening a pak file, for example there is also FS::PakPath::ReadFile. So it's not exactly correct. |
To be sure we talk about the same thing: the purpose of this is to only list what's loaded because of it being used, not to list what's available. |
can we merge this? |
This only handles stuff from the legacy code paths I think? Daemon/src/common/FileSystem.cpp Line 710 in 3a29a12
|
I don't know what you are talking about 🤔 |
note that we can rename the |
I just renamed from |
It only counts files that were opened with |
Ah ok now I understand. |
old commit by @slipher initially wrote for kharnov's purpose, was intensively used to clean-up the game packs from dust for 0.51 release. This is also very convenient to check if a file is loaded as expected, like for troubleshooting #159.
Note that some files are loaded dynamically, so be sure to have spawned any character model / weapon and have walked any possible menu to be sure every used file is listed.
I modified the patch a bit to make it working on the now-extracted engine directory, reverted to lowercase
override
and did some camelCase, whitespace and blank line bikeshedding.I don't know why this was never merged before, is there any issue with it?