0.52.0/sync #418
Closed
0.52.0/sync #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps the CMake version to 3.13 and fixes deprecations warnings that were raised in toolchain-nacl.cmake as well as deletes some code paths that were for older CMake versions. Not that 3.13 is what's in Debian stable and oldstable has backports for 3.16. CMakeForceCompiler is deprecated so instead we set CMAKE_C/CXX_COMPILER directly. This causes CMake to not set CMAKE_C/CXX_COMPILER_ID (because it can't determine it automatically) so the CMakeLists.txt had to support an empty CMAKE_CXX_COMPILER_ID and a special case for PCH support on NaCl. Getting a target's location as done in pnacl_translate is deprecated so instead we compute the paths to the various targets/nexe/pexe directly from the build dir and the gamemodule dir. Also remove our local copy of CMakeParseArguments as it is a builtin function since CMake 3.4. Fixes DaemonEngine#412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.