RSS 2.0 + atom support #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dch
commented
Mar 11, 2021
lib/serum/plugins/rss_generator.ex
Outdated
| defp create_file(dest, pages, posts) do | ||
| %Serum.File{ | ||
| dest: Path.join(dest, "rss.xml"), | ||
| out_data: rss_xml(pages, posts, &to_rfc822_format/1, bindings()) |
There was a problem hiding this comment.
I don''t understand exactly what these 3 & 4th parameter are supposed to do
- what input & return typespec this 3rd function is supposed to have
- how to ensure variables are available in template
dch
commented
Mar 11, 2021
dch
commented
Mar 11, 2021
| <atom:link href="<%= Path.join(Map.fetch!(bindings, :server_root), "/~dch/rss.xml") %>" rel="self" type="application/rss+xml" /> | ||
| <%= for post <- posts do %><item> | ||
| <link><%= Path.join(Map.fetch!(bindings, :server_root), post.url) %></link> | ||
| <guid><%= Path.join(Map.fetch!(bindings, :server_root), post.url) %></guid> |
There was a problem hiding this comment.
OMG the bindings this is clearly wrong!
Open
|
@Dalgona any chance this could make it into v1? |
dch
force-pushed
the
main
branch
7 times, most recently
from
63c52f3
to
637cb89
Compare
on many systems, gen_tcp will not open if port is already in use. Ignore the error, and rely on the subsequent clause to validate the test failure.
|
@Dalgona this PR brings rss + elixir 1.16/otp26 compatibility. Would be nice to have it reviewed and merged, and published to hex when you have time. |
Passes common validators like: - https://www.rssboard.org/rss-validator/ - https://validator.w3.org/feed/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this quickly but it does pass W3C RSS feed validation.
some things I need advice on:
serum.exs?