Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added write functionality within run with optional flag, defaulting t… #226

Merged
merged 8 commits into from Nov 12, 2021

Conversation

surya-narayanan
Copy link
Contributor

added write functionality within run with optional flag, defaulting to False

@jacob-rosenthal jacob-rosenthal changed the base branch from master to dev November 11, 2021 18:39
@jacob-rosenthal
Copy link
Collaborator

jacob-rosenthal commented Nov 11, 2021

Thanks for leading this, Surya!!

I modified the syntax a little bit to make it more streamlined (one argument instead of two) and to ensure compatibility with both SlideData.run() and also SlideDataset.run(). That's why we now pass a directory, instead of a file path. I also added tests. Finally, I changed the PR to merge to dev instead of master to follow our workflows

Let me know what you think! Thanks for suggesting this feature!!

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #226 (30cfc9e) into dev (0edc110) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #226      +/-   ##
==========================================
+ Coverage   85.23%   85.24%   +0.01%     
==========================================
  Files          25       25              
  Lines        2533     2535       +2     
==========================================
+ Hits         2159     2161       +2     
  Misses        374      374              
Impacted Files Coverage Δ
pathml/core/slide_data.py 85.23% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0edc110...30cfc9e. Read the comment docs.

@surya-narayanan
Copy link
Contributor Author

Awesome stuff guys! Let's go!!!

@ryanccarelli ryanccarelli merged commit 1308b58 into dev Nov 12, 2021
@ryanccarelli ryanccarelli deleted the myFeature branch November 12, 2021 02:15
@jacob-rosenthal jacob-rosenthal mentioned this pull request Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants