Implement a basic CI/CD

[DaniAsh551]

I was thinking, we may benefit from some form of CI/CD to do basic sanity checks (like linting) while submitting any given commit.
This can be a start and we can see how we can improve from there.

A basic debian/archlinux runner with python should be fine.

Later, we can add conditions for doing more extensive checks than simple linting. Maybe even move to some form of version system if that would help??

What do you think @marvin1099 @JohnHamwi ?

[DaniAsh551]

to add to the previous message, we could also adopt a sane branching strategy once we get the CI/CD functional, where the main branch will always be stable. Development will happen on other branches.

[marvin1099]

I thought about a dev branch to, that one would be simple, i would say we do that one.
Next a CI/CD system for that we would probably need something like a GitHub action,
that can check, something like the syntax.
I think that would be nice but i have no idea on how these work,
if you or @JohnHamwi have some idea on how to do it, than it sound good by me.

[DaniAsh551]

Dont worry about it, I can make a good enough CI/CD.

I mentioned this to you because you are the only developer who is active on this.

So, I'll write some actions/tasks and enable them and let you know

[marvin1099]

by the way can you tell me what this branch was for feat/deref,
I don't think its relevant anymore so i like to remove it, but i don't want to delete anything important.
Also i have created a "dev" branch, so now I push to that fist and merge after I'm sure it works.

[marvin1099]

Dont worry about it, I can make a good enough CI/CD.

I mentioned this to you because you are the only developer who is active on this.

So, I'll write some actions/tasks and enable them and let you know

Sounds great.

[DaniAsh551]

I would say, at this point, anything other than the main branch is not really needed.

Deref was to test the functionality to dereference all the symlinks in the prefix (this prevented WeMod from working on anything except GE7-35 in the past). But its been merged into main since then

[DaniAsh551]

Instead of a single dev branch where development will happen, we can also follow feature branching if youd prefer that, but a Dev branch should work just fine for us

Once the CI matures, we can even implement auto PR/merge to main too if the checks pass

[marvin1099]

Instead of a single dev branch where development will happen, we can also follow feature branching if youd prefer that, but a Dev branch should work just fine for us

Once the CI matures, we can even implement auto PR/merge to main too if the checks pass

Sounds good as well.

[marvin1099]

so since you don't have lots of time i checked some stuff and i saw the Pyre workflow, that might work.
That would be a basic CI system, but it also seems that Type Annotations will need to be added in this case,
but that is simple enough to figure out for me.
I also added some code that will merge from dev.
Tell me what you have thought of

That file will be in the workflows folder later

name: Pyre

on:
  workflow_dispatch:
  push:
    branches: [ "main", "dev" ]
  pull_request:
    branches: [ "main", "dev" ]

permissions:
    contents: read

jobs:
  pyre:
    permissions:
      actions: read
      contents: read
      security-events: write
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
        with:
          submodules: true

      - name: Run Pyre
        uses: facebook/pyre-action@60697a7858f7cc8470d8cc494a3cf2ad6b06560d
        with:
          # To customize these inputs:
          # See https://github.com/facebook/pyre-action#inputs
          repo-directory: './'
          requirements-path: 'requirements.txt'

      - name: Auto-merge to main on successful checks
        if: github.ref == 'refs/heads/dev' && success()
        run: |
          git config --global user.name 'github-actions[bot]'
          git config --global user.email 'github-actions[bot]@users.noreply.github.com'
          git checkout main
          git merge dev
          git push origin main
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

[marvin1099]

This seems way to complicated actually, I'm trying some stuff but for now this is not a good solution.

[marvin1099]

@DaniAsh551 So i have made something that will format code merge from dev to main and back and find comon errors, check this merge, i think i will merge it tomorrow: pull 71

[marvin1099]

It seems github actions do not have whrite access, i think you will need to enable that, would you do that @DaniAsh551?

[DaniAsh551]

Hey @marvin1099 , so sorry for being so absent, I have been preparing to travel for health related reasons.

Anyway, I am very thankful that you are working on the project still. I have enabled Actions with all permissions

[marvin1099]

Hey @marvin1099 , so sorry for being so absent, I have been preparing to travel for health related reasons.
Anyway, I am very thankful that you are working on the project still. I have enabled Actions with all permissions

You don't have to explain yourself,
I understand that you have other things to do.
Not everyone wants on can invest time into some random project.
I mean the reason why I'm doing this is because i have fun programming
and on this project people even use some part of my work,
this is not the case my other GitHub projects, therefore I enjoy this.
I appreciate that you responded even if you where occupied,
and its good to know what is going on.