Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Additional HTTP Methods in axum-js #4

Closed
Daniel-Boll opened this issue Oct 7, 2023 · 0 comments · Fixed by #17
Closed

Implement Additional HTTP Methods in axum-js #4

Daniel-Boll opened this issue Oct 7, 2023 · 0 comments · Fixed by #17
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed implementation

Comments

@Daniel-Boll
Copy link
Owner

To make axum-js a more comprehensive and versatile API framework, it's essential to extend support to all standard HTTP methods. As of now, only the get method is implemented. This task involves adding the remaining standard HTTP methods: post, put, delete, options, head, patch, trace, and connect.

Each method should accept a path (as a string) and a callback function, similar to the existing get method. This enhancement should follow the pattern established in Issue #3 (Extend get Method to Support Callbacks).

Example for the post method:

app.post('/', (req, res) => {
  res.send('Post request received!')
});

Acceptance Criteria:

  • Implement the post, put, delete, options, head, patch, trace, and connect methods, adhering to the callback support pattern established in Issue Extend get Method to Support Callbacks #3.
  • Ensure each method accepts a path string and a callback function as arguments.
  • Update the type definitions, documentation, and tests to reflect these new methods.
  • The implementation should adhere to the project’s STYLE_GUIDE.md and be consistent with existing code patterns.
  • Create a PR with the necessary code changes, updated documentation, and tests.

Dependencies:

Additional Context:

Implementing these additional HTTP methods will significantly enhance the versatility and utility of axum-js, aligning it with other full-featured server frameworks.

@Daniel-Boll Daniel-Boll added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers implementation hacktoberfest labels Oct 7, 2023
@Daniel-Boll Daniel-Boll self-assigned this Oct 9, 2023
@Daniel-Boll Daniel-Boll linked a pull request Oct 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed implementation
Projects
None yet
1 participant