Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to change named parameters color in color theme? #1900

Closed
JCKodel opened this issue Aug 1, 2019 · 7 comments
Closed

How to change named parameters color in color theme? #1900

JCKodel opened this issue Aug 1, 2019 · 7 comments
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement
Milestone

Comments

@JCKodel
Copy link

JCKodel commented Aug 1, 2019

image

It is possible (and if yes, how) to colorize only the named parameters in VSCode?

(notice in the example above that common text still white, while only named parameters are yellow)

@DanTup
Copy link
Member

DanTup commented Aug 1, 2019

I don't think it's currently possible - though is your screenshot from VS Code or IntelliJ? If VS Code, which theme is it that shows them in yellow?

@JCKodel
Copy link
Author

JCKodel commented Aug 1, 2019 via email

@DanTup
Copy link
Member

DanTup commented Aug 5, 2019

Oh, I see :-)

In theory, I think it shouldn't be difficult to assign these a different scope so they could be coloured differently. In practice, every time I change the grammar file I break stuff 😄 I'll see what I can do though.

@DanTup DanTup added this to the v3.4.0 milestone Aug 5, 2019
@DanTup DanTup added in editor Relates to code editing or language features is enhancement labels Aug 5, 2019
@DanTup DanTup modified the milestones: v3.4.0, v3.5.0 Aug 26, 2019
@DanTup DanTup modified the milestones: v3.5.0, v3.6.0 Oct 1, 2019
@DanTup DanTup modified the milestones: v3.6.0, v3.7.0 Oct 28, 2019
@DanTup
Copy link
Member

DanTup commented Nov 20, 2019

Upon reviewing the syntax file, I don't think this would be easy. I think there may be upcoming changes to how syntax highlighting works in VS Code (switching to another format from textmate grammars) so I think it would be better to handle this then (since the new format may be better, and may be more easily testable!).

@DanTup DanTup modified the milestones: v3.7.0, On Deck Nov 20, 2019
@SoKamil
Copy link

SoKamil commented May 22, 2020

microsoft/vscode#95958
They did something and also they introduced semantic highlighting for TS and JS, and they have announced it for Java and C++

@DanTup
Copy link
Member

DanTup commented May 25, 2020

I do plan to support semantic highlighting - but it will be using LSP (which we're migrating to, but it doesn't have semantic highlighting support yet - the API is still only proposed).

@DanTup DanTup added the in lsp/analysis server Something to be fixed in the Dart analysis server label Jun 22, 2020
@DanTup DanTup modified the milestones: On Deck, v3.18.0, v3.19.0 Dec 10, 2020
@DanTup
Copy link
Member

DanTup commented Jan 19, 2021

Once https://dart-review.googlesource.com/c/sdk/+/179769 lands (and you're on an SDK that uses it and have the LSP Preview enabled), you'll be able to set the colours of parameter names at call sites with the following settings:

	"editor.semanticTokenColorCustomizations": {
		"rules": {
			"parameter.label": "#990",
		},
	},

Screenshot 2021-01-19 at 10 35 26

@DanTup DanTup closed this as completed Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement
Projects
None yet
Development

No branches or pull requests

3 participants