-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a command to "Add SDK to Path" and offer to invoke it automatically after downloading an SDK [Windows] #4604
Comments
@polina-c is this doc public? Does it have a public URL? go / goto.google.com links don't work for non-Googlers (they require logging in with a google account) |
Tweaked the title a bit because this should be a command you can use even when not downloading. I managed to get the command working on Windows today using PowerShell (at least, it works on my machine). It reports whether it was a) added, b) failed to add or c) already on PATH. I haven't done any testing on Mac yet (or had the download prompt to do it automatically), but since VS Code is already doing that I expect it shouldn't be too difficult. |
Will we have telemetry for ratio of successful cases? |
I'd like to record the number of successful/unsuccessful attempts for both git clone and adding to path (for opted-in users). |
It is not public. Yes, it works just for googlers. And it is ok for this case. |
I've merged in some changes for this:
I've included this in a pre-release version today (v3.67.20230626), though the "git clone" flow is still behind the |
I'm making this issue Windows-specific (and closing because it's merged) and have opened #4612 to track macOS, since I suspect there may be more discussion (and complications). I don't want to hold up the current work (which should work for Windows, and can also open instructions for other platforms) if we don't get a Mac solution before the next release. @polina-c btw, if we can't add automatically, these are the URLs I'm currently linking to for manual instructions - we can tweak these if required: Dart-Code/src/shared/constants.ts Lines 90 to 96 in 3d3238d
|
Is there auto-testing that links are not broken? This is what we have in DevTools:
|
Not currently, but it'd be nice to have - I opened #4617 |
@wildsylvan can you file a new issue for this, and include steps/screenshots showing how you're checking this? We do add quotes here:
But the comment suggests that it didn't work without them so it might need some more testing. Please also include your version of Windows and PowerShell in the new issue. Thanks! |
@DanTup done 👍🏾 |
go/setup-path-with-flutter-extension
The text was updated successfully, but these errors were encountered: