Added Powerplay to PerDeviceDeviceDefinitions #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why this target branch? It shouldn't conflict with the lightspeed detector as far as I know, but at least replace the PerZone definition already in |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I once again added the Powerplay to PerDeviceDeviceDefinitions.
When it is defined in PerZoneDeviceDefinitions a LedMapping dictionary error occurres.
This is because the layout for the powerplay (which I authored back then) specifies the sinlge zone as 'Custom1'.
This is the LedMapping for PerDeviceDevices and does not work with PerZoneDevices.
I tried to resolve this with changing the layout to use the ZoneMousepad mapping, but this just refused to work.
So I propose this solution to fix the Powerplay once and for all. (hopefully)
This is verified to work with my Powerplay and G502 Lightspeed.