-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[question]video-audio bitrate correlation #1319
Comments
There is no way to do that in the current code base. They are , as you pointed out, completly independent. Easiest way to solve this is for Dash.js to re-allow Muxed content. |
@AkamaiDASH Sorry, i did not get about "to re-allow Muxed content". Google search for "dash.js muxed content" gives nothing reasonable. |
No problem, let me explain. We use to allow single fragment audio/video (muxed content) in dash.js but @ v1.4 we stopped since it was out of compliance with the MPEG DASH guidelines. We have talked about lifting this restriction with a settable API flag to work in non-compliance mode. |
@AkamaiDASH So i have another proposal. So while player attempting to download video-fragment-2, other audio fragments already downloaded - so while audio was downloading - bandwith was taking for them - instead of let this bandiwth be used for downloading video fragment more faster. So in this situation player stalls, becuase video frag still not downloaded. I suppose it would be better to implement logic for video-audio downloading: for audio frags will not be downloaded more then one video ahead, for example: |
@AkamaiDASH, please, comment, and maybe reopen an issue for "Feature Enhancment" |
Others have mentioned the unevenness. Only an issue with incredibly slow connection but still an issue nonetheless. I agree we should balance it a bit more. We use to have an incredibly complex way for this and I think there is a very easy way to solve. We just need to manage the buffer targets individually for audio and video. Possibly divide current video bitrate by current audio bitrate * seg duration to set an audio target. I will mark this a enhancement and try to get into next release. |
@kuznetcoff777 and @KarishmaBagga I have implemented a very simple yet very effective solution for this and will commit it soon. Basically I always set the audio buffer target to the video's buffer length allowing video to grow larger first and have XHR priority. few lines of code was all that was needed. I will share soon. |
Ok i have added code to balance audio and give video priority. Not much testing yet but I think it will be good. I will test next week but you can find code here |
Hello! Here is the issue:
3 video bitrates that has their own audio bitrates (for example 4000---256; 2000---128; 1000---64)
Player takes video and audio separately, so i got that moment:
I watch 1000 video bitrate (so buffer keeps about 12-20 seconds) and audio takes 256kbit fragments. So by logic of player it assumes this audio bitrate as the top, so player downloads audio fragments for 60 seconds ahead).
So i suppose it is not good. Is there any way to correlate video-audio bitrates, for my example, that when plays 4000 video then it have to take only 256 audio and so on (2000---128; 1000---64)?
The text was updated successfully, but these errors were encountered: