Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video-audio-caption download correlation #964

Closed
kuznetcoff777 opened this issue Aug 11, 2017 · 7 comments
Closed

video-audio-caption download correlation #964

kuznetcoff777 opened this issue Aug 11, 2017 · 7 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@kuznetcoff777
Copy link

Have you read the FAQ and checked for duplicate issues:yes

What version of Shaka Player are you using:v2.1.6

Can you reproduce the issue with our latest release version:yes

Can you reproduce the issue with the latest code from master:

Are you using the demo app or your own custom app:demo

If custom app, can you reproduce the issue using our demo app:

What browser and OS are you using:chrome/ff

What are the manifest and license server URIs:
(you can send the URIs to shaka-player-issues@google.com instead, but please use GitHub and the template for the rest)

**What did you do?**opened stream and waited

What did you expect to happen? stream must play as fast as possible

What actually happened? several seconds to wait additionally

I throttled chrome to low network speed and saw that palyer downloaded segments in this way:
video-fragment-1(downloaded)
audio-fragment-1(downloaded)
caption-fragment-1(downloaded)
audio-fragment-2(downloaded)
caption-fragment-2(downloaded)
audio-fragment-3(downloaded)
caption-fragment-3(downloaded)
audio-fragment-4(downloaded)
video-fragment-2(still downloading)
caption-fragment-4(downloaded)
audio-fragment-5(downloaded)
caption-fragment-5(downloaded)

So video/audio/caption downloading is not correllated. If player have no video, why downlaod audio and caption? The same problem i described at Dash-Industry-Forum/dash.js#1319
Can you make same fix here? It will be very helpful for low speed users.

@joeyparrish
Copy link
Member

From the dash.js code you referenced, it would seem that you want us to avoid buffering more audio than we have already buffered for video. Is that correct?

Can you explain the problem a bit more? Why is it wrong to buffer video and audio independently?

Do you expect us to wait until a video segment is buffered before fetching the corresponding audio segment? Or fetch them simultaneously?

@joeyparrish joeyparrish self-assigned this Aug 11, 2017
@joeyparrish joeyparrish added status: waiting on response Waiting on a response from the reporter(s) of the issue type: enhancement New feature or request labels Aug 11, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Aug 11, 2017
@joeyparrish joeyparrish removed their assignment Aug 11, 2017
@kuznetcoff777
Copy link
Author

"you want us to avoid buffering more audio than we have already buffered for video. Is that correct?" - correct
"Do you expect us to wait until a video segment is buffered before fetching the corresponding audio segment? Or fetch them simultaneously?" - both methods wiil be ok, because at the moment available bandwith is used for downloading future audio-captions, but this bandwith could be used to download necessary video segment:

@kuznetcoff777
Copy link
Author

So, is it possible?

@joeyparrish joeyparrish removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 17, 2017
@joeyparrish
Copy link
Member

I think this is feasible. Tentatively scheduled for v2.3.

@joeyparrish joeyparrish modified the milestones: v2.3.0, v2.4.0, Backlog Dec 4, 2017
@joeyparrish joeyparrish modified the milestones: Backlog, v2.4 Mar 23, 2018
@joeyparrish joeyparrish self-assigned this Mar 23, 2018
@joeyparrish
Copy link
Member

We hadn't planned to work on this right now, but it came up while working on another issue. It seems to help that other issue, and it is fairly simple, so we will clean it up and try to get it out soon.

joeyparrish added a commit that referenced this issue Mar 29, 2018
No one media type will be streamed far ahead of any other.  The limit
will be the max duration of one segment.

Backported to v2.3.x

Bug: 75276747  (mitigates)
Closes #964

Change-Id: I0f118e73912b46c987e58d4a5c123acf8412be0b
@joeyparrish
Copy link
Member

Fix cherry-picked to v2.3.5.

@kuznetcoff777
Copy link
Author

@joeyparrish Thanks!

@shaka-project shaka-project locked and limited conversation to collaborators May 26, 2018
rounce pushed a commit to rounce/shaka-player that referenced this issue Jul 8, 2019
No one media type will be streamed far ahead of any other.  The limit
will be the max duration of one segment.

Bug: 75276747  (mitigates)
Closes shaka-project#964

Change-Id: I0f118e73912b46c987e58d4a5c123acf8412be0b
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants