-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All segments from time zero are reloaded when switching track #1369
Comments
@bbcrddave you happen to have a good multi-track test stream i am work this one out with? |
Oh that is wonderful! OK I am able to reproduce this and will fix. |
Easy to fix but need to make sure i do not break the original PR so it will take me some time to validate the fix. Thanks for catching this one guys. |
OK I am pretty happy with fix so far and MP works just as well post change. Current time was already passed on track change to create stream processor but not set on index handler in the optional settings , with this line it picks up at the playhead not at id 1.
I want to make sure I am not fixing one thing and breaking something else so i need do a bit more digging on the change that took this line out which is different from the #1242 PR |
If I have understood this bug correctly, I think this is blocking us from deploying 2.1.1 as switching languages is a big issue for us and CDN costs as well. |
You can fix with a one line change so do not let it block you. Ill push the change today in to dev branch. Sorry for the blocker guys. |
…sh-Industry-Forum#1369. This was done as a hack before I fixed the actual problem with MP for FireFox and issue Dash-Industry-Forum#1217 This commit will fix Dash-Industry-Forum#1369
@AkamaiDASH thanks for pointing out. |
@bwidtmann I have pushed it into dev (32f6982) |
#1242 seems to have caused a regression when switching tracks while fixing multiperiod.
This is because when a new StreamProcessor is created, its currentTime is no longer set which causes the scheduler to start from zero.
This was reported on another ticket - I've copied and pasted the detail below:
@esteban-dosztal wrote:
The text was updated successfully, but these errors were encountered: