Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate BaseURL failover broken #1702

Closed
davemevans opened this issue Dec 12, 2016 · 3 comments
Closed

Alternate BaseURL failover broken #1702

davemevans opened this issue Dec 12, 2016 · 3 comments
Milestone

Comments

@davemevans
Copy link
Contributor

It looks like 636f4f9 has broken BaseURL failover.

This appears to be because the scheduler is not running when a failure occurs, and this is required in order to re-request segments from an alternative BaseURL. It used to be the case that replacement requests were downloaded immediately but this seems to have been replaced with a queue which is serviced by a scheduler.

More as we have it.

#1701 is also required.

@davemevans
Copy link
Contributor Author

I think we have a fix which could be PR'ed tomorrow after some internal review.

@dsparacio
Copy link
Contributor

the Replacement queue was put in for fast switching in May. Can we not invoke the scheduler method outside of the timer based on some failover signal or error?

@davemevans
Copy link
Contributor Author

Can we not invoke the scheduler method outside of the timer based on some failover signal or error?

Pretty much, yes. Needed a further tweak to ensure initialisation segments were handled correctly.

dsparacio pushed a commit that referenced this issue Dec 13, 2016
Fix #1702 - ensure replacements are rerequested on failure
robertbryer pushed a commit to bbc/dash.js that referenced this issue Dec 14, 2016
@dsparacio dsparacio added this to the v2.4.0 milestone Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants