Fix #1702 - ensure replacements are rerequested on failure #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#1701 is also needed in also to make this work properly. |
dsparacio
approved these changes
Dec 13, 2016
|
@bbcrddave thanks for this last minute change. Sorry If I broke this! Interesting enough, I remember us talking about this last May when the changes were put in and I was being very careful to check replacement for BASEURL but I guess I missed something. Was all BaseURL broken or just a certain use case? |
|
All broken, but not a problem since obviously no one has been using it up to now 😉 |
|
OK thanks. Agreed. I am tired of talking about it - time for action. Time to backfill the missing tests, add proper coverage reporting, and start to only accept PR with test associated with the change. . I will add it to the agenda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1702, the fast switch changes meant that alternate base urls were not failed to in the event of a download failure. This is fixed by kicking the scheduler once the replacement queue has been populated.
Additionally, extra checks are needed to ensure that if it was an initialisation segment that failed this can be rerequested since next fragment rule will not replace these.