MediaPlayer autoplay not working correctly

[wilaw]

There are a number of problems here

1. The baseline.html sample calls player.autoPlay = true; when autoPlay is not a property of MediaPlayer. The correct call is player.setAutoPlay(true);
2. If you use mediaPlayer.setAutoPlay(false), then playback does not autoplay, however it also does not start if the play button is pressed on the video controls.
3. In MediaPlayer.js, the attachView function hard codes the element autoplay to true. This means that if player.attachView is called after player.setAutoPlay, then the previous autoplay setting is overridden. The order in which the following calls are made against a MediaPlayer instance should not matter

player.attachView
player.setAutoPlay
player.attachSource

[nweber]

This is fixed in my latest pull request, with one caveat... You cannot call both attachSource and attachView BEFORE calling setAutoPlay(false). Because autoPlay defaults to true, if both the view and the source are set the video will autoPlay, as per the correct default setting. I believe this is the correct, expected behavior.