v2.5.0: VOD does not play through until end #1901
Comments
|
EDIT: updated with completely conformant stream. Which seems weird as all 7 are encoded the same way. |
|
Bisected several times to 29c0eff as first bad commit. |
|
Reverting 29c0eff fixes the problem for me[tm]. |
|
Ping ;-) |
|
Working in nightly - looping each time. Can you try here |
|
@AkamaiDASH - thanks, but, no, for me it's still the same problem, sorry. |
|
@AkamaiDASH - did you really try with e.g. https://edge.flowplayer.org/night4.mpd ? |
|
It works rather well in Chrome, but not 100% reliably, but almost never in Firefox or Safari. |
|
@AkamaiDASH - if I do the equivalent to reverting 29c0eff on the latest development: diff --git a/src/streaming/controllers/StreamController.js b/src/streaming/controllers/StreamController.js
index 1db74493..6187a61e 100644
--- a/src/streaming/controllers/StreamController.js
+++ b/src/streaming/controllers/StreamController.js
@@ -305,6 +305,7 @@ function StreamController() {
if (oldStream) oldStream.deactivate();
activeStream = newStream;
playbackController.initialize(activeStream.getStreamInfo());
+ videoTrackDetected = checkTrackPresence(Constants.VIDEO);
//TODO detect if we should close and repose or jump to activateStream.
openMediaSource(seekTime);
@@ -349,8 +350,6 @@ function StreamController() {
});
playbackController.seek(startTime); //seek to period start time
}
- } else {
- videoTrackDetected = checkTrackPresence(Constants.VIDEO);
}
activeStream.startEventController();the problem again goes away. |
…SwitchStream, done in composeStreams. The problem is, at this specific time, no StreamProcessor has been built. The return value of this function is always false." This reverts commit 29c0eff. To ensure VOD is always played until end (Dash-Industry-Forum#22). See: Dash-Industry-Forum#1901
|
ping ;-) this problem is still present in Firefox 55, and arguably it's somewhat basic. |
|
@spiterikevin - indeed your change seems to solve the problem. |
|
@spiterikevin - hm, there's still trouble with some streams, for instance http://edge.flowplayer.org/moon.mpd - again, no problem with the revert hack. |
|
No. It's better, but not as reliable as the "broken" approach, which always works in this regard. Especially in Firefox with empty cache, starting, and jump seeking towards the end. |
|
And when it hangs, the following is repeated over and over in the console: HTH. |
|
Interesting. I am reproducing this error, but it is not as consistently reproducible. And I'm also occasionally getting it even with the revert fix. I don't yet understand what's going on and will look into it more. |
|
@spiterikevin - much appreciated. |
|
@spiterikevin - not 100% sure whether you meant me to test with all 4 patches applied: but that's what I did, and it seems to solve the issue. |
|
@blacktrash Yes, that's what I meant. Thank you for flagging the issue and testing it. |
|
@spiterikevin - thank you. |
|
@spiterikevin - I did not follow the fate of your patches closely, but from my perspective all seems fine with v2.6.0. |
|
@blacktrash, closing this issue as it seems to be fixed. Please, feel free to reopen it in case you can reproduce the issue again. Many thanks! |
Environment
Steps to reproduce
Go to http://dashif.org/reference/players/javascript/v2.5.0/samples/dash-if-reference-player/ and play http://edge.flowplayer.org/night4.mpd
May sometimes not happen if stream is cached, so cache-refresh before testing.
Observed behaviour
Stops before end instead of looping.
Does not happen e.g. at http://dashif.org/reference/players/javascript/v2.4.1/samples/dash-if-reference-player/ or below.
Console output
The text was updated successfully, but these errors were encountered: